All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Hao-Yu Yang <naup96721@gmail.com>
Cc: security@kernel.org, tglx@kernel.org, mingo@redhat.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] futex: Use-after-free between futex_key_to_node_opt and vma_replace_policy
Date: Fri, 13 Mar 2026 13:44:23 +0100	[thread overview]
Message-ID: <2026031349-aging-colonize-39a0@gregkh> (raw)
In-Reply-To: <20260313123940.51301-1-naup96721@gmail.com>

On Fri, Mar 13, 2026 at 08:39:40PM +0800, Hao-Yu Yang wrote:
> During futex_key_to_node_opt() execution, vma->vm_policy is read under
> speculative mmap lock and RCU. Concurrently, mbind() may call
> vma_replace_policy() which frees the old mempolicy immediately via
> kmem_cache_free().
> 
> This creates a race where __futex_key_to_node() dereferences a freed
> mempolicy pointer, causing a use-after-free read of mpol->mode.

As this is sent to lkml in public, no need to get security@k.o involved.

> [  151.412631] BUG: KASAN: slab-use-after-free in __futex_key_to_node (kernel/futex/core.c:349)
> [  151.414046] Read of size 2 at addr ffff888001c49634 by task e/87
> [  151.414476]
> [  151.415431] CPU: 1 UID: 1000 PID: 87 Comm: e Not tainted 7.0.0-rc3-g0257f64bdac7 #1 PREEMPT(lazy)
> [  151.415758] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.15.0-1 04/01/2014
> [  151.415969] Call Trace:
> [  151.416059]  <TASK>
> [  151.416161]  dump_stack_lvl (lib/dump_stack.c:123)
> [  151.416299]  print_report (mm/kasan/report.c:379 mm/kasan/report.c:482)
> [  151.416359]  ? __virt_addr_valid (./include/linux/mmzone.h:2046 ./include/linux/mmzone.h:2198 arch/x86/mm/physaddr.c:54)
> [  151.416412]  ? __futex_key_to_node (kernel/futex/core.c:349)
> [  151.416517]  ? kasan_complete_mode_report_info (mm/kasan/report_generic.c:182)
> [  151.416583]  ? __futex_key_to_node (kernel/futex/core.c:349)
> [  151.416631]  kasan_report (mm/kasan/report.c:597)
> [  151.416677]  ? __futex_key_to_node (kernel/futex/core.c:349)
> [  151.416732]  __asan_load2 (mm/kasan/generic.c:271)
> [  151.416777]  __futex_key_to_node (kernel/futex/core.c:349)
> [  151.416822]  get_futex_key (kernel/futex/core.c:374 kernel/futex/core.c:386 kernel/futex/core.c:593)
> [  151.416871]  ? __pfx_get_futex_key (kernel/futex/core.c:550)
> [  151.416927]  futex_wake (kernel/futex/waitwake.c:165)
> [  151.416976]  ? __pfx_futex_wake (kernel/futex/waitwake.c:156)
> [  151.417022]  ? __pfx___x64_sys_futex_wait (kernel/futex/syscalls.c:398)
> [  151.417081]  __x64_sys_futex_wake (kernel/futex/syscalls.c:382 kernel/futex/syscalls.c:366 kernel/futex/syscalls.c:366)
> [  151.417129]  x64_sys_call (arch/x86/entry/syscall_64.c:41)
> [  151.417236]  do_syscall_64 (arch/x86/entry/syscall_64.c:63 arch/x86/entry/syscall_64.c:94)
> [  151.417342]  entry_SYSCALL_64_after_hwframe (arch/x86/entry/entry_64.S:130)
> [  151.418312]  </TASK>
> 
> Fix by adding rcu to __mpol_put().
> 
> change-log:
>  v2-v1: add rcu to __mpol_put

This goes below the --- line.

> 
> Fixes: c042c505210d ("futex: Implement FUTEX2_MPOL")
> Reported-by: Hao-Yu Yang <naup96721@gmail.com>
> Signed-off-by: Hao-Yu Yang <naup96721@gmail.com>
> ---

No cc: stable?

thanks,

greg k-h

  reply	other threads:[~2026-03-13 12:44 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-13 12:39 [PATCH v2] futex: Use-after-free between futex_key_to_node_opt and vma_replace_policy Hao-Yu Yang
2026-03-13 12:44 ` Greg KH [this message]
2026-03-13 12:51   ` Hao-Yu Yang
2026-03-13 12:52 ` Peter Zijlstra
2026-03-13 12:55   ` Eric Dumazet
2026-03-13 13:01     ` Hao-Yu Yang
  -- strict thread matches above, loose matches on Subject: below --
2026-03-13 12:47 Hao-Yu Yang
2026-03-21 23:57 ` Hao-Yu Yang
2026-03-22 21:42   ` Thomas Gleixner
2026-03-23 17:24 ` Thomas Gleixner
2026-03-23 23:43   ` Hao-Yu Yang
2026-03-23 23:46   ` Hao-Yu Yang
2026-03-24 14:00   ` Peter Zijlstra
2026-03-24 15:54     ` Hao-Yu Yang
2026-03-24 16:36     ` Thomas Gleixner
2026-03-24 17:44       ` Peter Zijlstra
2026-03-24 19:25         ` Thomas Gleixner
2026-03-24 20:27         ` David Hildenbrand (Arm)
2026-03-25 15:14           ` Peter Zijlstra
2026-03-25 15:19             ` Eric Dumazet
2026-03-25 15:22               ` Peter Zijlstra
2026-03-25 15:24                 ` David Hildenbrand (Arm)
2026-03-25 15:25                 ` Eric Dumazet
2026-03-26 12:42                   ` Hao-Yu Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026031349-aging-colonize-39a0@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=naup96721@gmail.com \
    --cc=security@kernel.org \
    --cc=tglx@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.