From: Jakub Kicinski <kuba@kernel.org>
To: geert+renesas@glider.be
Cc: Jakub Kicinski <kuba@kernel.org>,
linux-renesas-soc@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, eichest@gmail.com, conor+dt@kernel.org,
krzk+dt@kernel.org, devicetree@vger.kernel.org,
andrew+netdev@lunn.ch, robh@kernel.org, davem@davemloft.net,
netdev@vger.kernel.org
Subject: Re: [2/2] dt-bindings: net: micrel: KSZ8041RNLI supports LED mode
Date: Fri, 13 Mar 2026 19:01:07 -0700 [thread overview]
Message-ID: <20260314020107.2241383-1-kuba@kernel.org> (raw)
In-Reply-To: <6ccda7a00f250e87b0457e276ac1070cb0708d71.1773321267.git.geert+renesas@glider.be>
This is an AI-generated review of your patch. The human sending this
email has considered the AI review valid, or at least plausible.
For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html
---
dt-bindings: net: micrel: KSZ8041RNLI supports LED mode
Micrel KSZ8041RNLI supports LED mode, just like KSZ8041. This fixes (a.o.)
the following "make dtbs_check" warning for the r8a7791-koelsch device tree.
> diff --git a/Documentation/devicetree/bindings/net/micrel.yaml b/Documentation/devicetree/bindings/net/micrel.yaml
> --- a/Documentation/devicetree/bindings/net/micrel.yaml
> +++ b/Documentation/devicetree/bindings/net/micrel.yaml
> @@ -54,6 +54,7 @@
> KSZ8021: register 0x1f, bits 5..4
> KSZ8031: register 0x1f, bits 5..4
> KSZ8041: register 0x1e, bits 15..14
> + KSZ8041RLNI: register 0x1e, bits 15..14
^^^^
This isn't a bug, but there's a typo here. Should this be KSZ8041RNLI
instead of KSZ8041RLNI?
The chip is called KSZ8041RNLI in the commit subject and in the compatible
string definition:
> KSZ8051: register 0x1f, bits 5..4
> KSZ8081: register 0x1f, bits 5..4
> KSZ8091: register 0x1f, bits 5..4
[ ... ]
> @@ -80,6 +81,7 @@
> contains:
> enum:
> - ethernet-phy-id0022.1510
> + - ethernet-phy-id0022.1537
> - ethernet-phy-id0022.1555
> - ethernet-phy-id0022.1556
> - ethernet-phy-id0022.1560
--
pw-bot: cr
next prev parent reply other threads:[~2026-03-14 2:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 13:27 [PATCH 0/2] dt-bindings: net: micrel: Fix KSZ8041RNLI dtbs_check warnings Geert Uytterhoeven
2026-03-12 13:27 ` [PATCH 1/2] dt-bindings: net: micrel: Sort lists Geert Uytterhoeven
2026-03-12 13:41 ` Stefan Eichenberger
2026-03-12 17:35 ` Conor Dooley
2026-03-12 13:27 ` [PATCH 2/2] dt-bindings: net: micrel: KSZ8041RNLI supports LED mode Geert Uytterhoeven
2026-03-12 13:45 ` Stefan Eichenberger
2026-03-12 17:35 ` Conor Dooley
2026-03-14 2:01 ` Jakub Kicinski [this message]
2026-03-16 8:22 ` [2/2] " Geert Uytterhoeven
2026-03-16 23:22 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260314020107.2241383-1-kuba@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=eichest@gmail.com \
--cc=geert+renesas@glider.be \
--cc=krzk+dt@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.