From: Jakub Kicinski <kuba@kernel.org>
To: lirongqing <lirongqing@baidu.com>
Cc: Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>,
Tariq Toukan <tariqt@nvidia.com>, Mark Bloch <mbloch@nvidia.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
"Paul E . McKenney" <paulmck@kernel.org>,
Frederic Weisbecker <frederic@kernel.org>,
<netdev@vger.kernel.org>, <linux-rdma@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
liyongkang <liyongkang01@baidu.com>
Subject: Re: [PATCH][net-next] net/mlx5: Expedite notifier unregistration during device teardown
Date: Sat, 14 Mar 2026 10:54:26 -0700 [thread overview]
Message-ID: <20260314105426.36ae4cba@kernel.org> (raw)
In-Reply-To: <20260312094804.2744-1-lirongqing@baidu.com>
On Thu, 12 Mar 2026 05:48:04 -0400 lirongqing wrote:
> During device hot-unplug, the mlx5 driver expects quickly unregister
> notification chains. The standard atomic_notifier_chain_unregister()
> calls synchronize_rcu(), which introduces significant latency and
> can become a bottleneck during mass resource cleanup.
>
> Introduce atomic_notifier_chain_unregister_expedited() to leverage
> synchronize_rcu_expedited(), and use it significantly reducing wait
> times in the following paths:
> - Event Queue (EQ) notifier chain
> - Firmware event notifier chain
> - IRQ notifier chain
>
> This acceleration ensures faster teardown during hot-unplug events.
Some detailed example and how long the whole operation takes would be
great in the commit msg.
> /**
> + * atomic_notifier_chain_unregister_expedited - Remove notifier from an atomic notifier chain
> + * @nh: Pointer to head of the atomic notifier chain
> + * @n: Entry to remove from notifier chain
> + *
> + * Removes a notifier from an atomic notifier chain and forcefully
> + * accelerates the RCU grace period.
> + *
> + * Returns zero on success or %-ENOENT on failure.
Warning: kernel/notifier.c:211 No description found for return value of 'atomic_notifier_chain_unregister_expedited'
kdoc wants you to use Return: or Returns: the colon is how it knows this
is the doc for return value not just a random mention of the word
Returns
--
pw-bot: cr
next prev parent reply other threads:[~2026-03-14 17:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 9:48 [PATCH][net-next] net/mlx5: Expedite notifier unregistration during device teardown lirongqing
2026-03-14 17:54 ` Jakub Kicinski [this message]
2026-03-16 2:21 ` 答复: [????] " Li,Rongqing(ACG CCN)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260314105426.36ae4cba@kernel.org \
--to=kuba@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=frederic@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=lirongqing@baidu.com \
--cc=liyongkang01@baidu.com \
--cc=mbloch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paulmck@kernel.org \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.