All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josh Law <objecting@objecting.org>
To: NeilBrown <neilb@suse.de>, Andrew Morton <akpm@linux-foundation.org>
Cc: Chuck Lever <chuck.lever@oracle.com>, linux-kernel@vger.kernel.org
Subject: [PATCH v2 2/2] lib/lwq: add missing module_exit for test module
Date: Sat, 14 Mar 2026 23:50:42 +0000	[thread overview]
Message-ID: <20260314235042.189833-3-objecting@objecting.org> (raw)
In-Reply-To: <20260314235042.189833-1-objecting@objecting.org>

From: Josh Law <objecting@objecting.org>

module_init(lwq_test) is declared without a corresponding module_exit,
preventing the module from being unloaded when built as a module.

Add an empty module_exit handler.

Signed-off-by: Josh Law <objecting@objecting.org>
---
 lib/lwq.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/lib/lwq.c b/lib/lwq.c
index 1fd2ed612c75..cf4d174d6898 100644
--- a/lib/lwq.c
+++ b/lib/lwq.c
@@ -157,5 +157,10 @@ static int lwq_test(void)
 	return 0;
 }
 
+static void lwq_test_exit(void)
+{
+}
+
 module_init(lwq_test);
+module_exit(lwq_test_exit);
 #endif /* CONFIG_LWQ_TEST*/
-- 
2.34.1


      parent reply	other threads:[~2026-03-14 23:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-14 23:50 [PATCH v2 0/2] lib/lwq: fixes for test module hang and unload Josh Law
2026-03-14 23:50 ` [PATCH v2 1/2] lib/lwq: fix potential kthread_stop() hang in test Josh Law
2026-03-14 23:50 ` Josh Law [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260314235042.189833-3-objecting@objecting.org \
    --to=objecting@objecting.org \
    --cc=akpm@linux-foundation.org \
    --cc=chuck.lever@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.