From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0152737186D for ; Sun, 15 Mar 2026 18:59:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773601146; cv=none; b=EMQjmoCo8A3xIsW6qnz83FuqmP0x7qK2+JfzXvxHorxFvxjoKKpJNDKluxz042B7wg4A4RFPo2wni5npQ5K2uxBDG15AC+BQA+b2mgL4UoH8gazXabH/rukx47fixOzah3Qj+ZKqAjeAFZKO6zN7Og9s7Q8dsNvB87nbXFXDNfM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773601146; c=relaxed/simple; bh=cG92xGH9WZWBy//57zeOYY4EGrjWkxOuj9kBCNQi1c8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=p3Mn7lgNVpGn1yTDkI4GdaQbktR3nplEPXXhLk2s9E3X9Br/lUeQNt/kK/Hs+9o5GwRECdwkTJmyEDWgfojY80e6VUywd38rLp5uwkuK8/Uo9pmFJdPfxg/NkOalieKqQaXmAmhEp+cL7HAC7JQS2p6+IK+5kZSy025BKOLXSQ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=koyk/iWL; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="koyk/iWL" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-439afc58ac7so4529062f8f.0 for ; Sun, 15 Mar 2026 11:59:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773601143; x=1774205943; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=PgdaL/zWdNdjo2VBs5fMH7nzqTNFHOZ8Z5QsCp8ugaU=; b=koyk/iWLUgOwEqudyQApGbSO82HNrGu5AyjQxmxUYu8uNXldcFpO88mvD5a0RPL5Au /6HuvUnrI49vexyUwOIcjj/jVX+zyKHGtuGY0r9kAEbe17Njnph+sAHesx5C2OtDiaOL FgJCy5/RIu/8Lij3LCJcje0BY5vpnXDUs1ksEOGKUzwIEfBiK9N7bD/IuNu5qhGx5a9q uNneAxXdWURg8Jf2GWUVo0pjqswnhMqD1bdoSZUy/MrDMnffC+8nJo8m0+eEFIAt2Ktn D1AW16NmvkHnGuUZ9BNfHNaCHxcpbAc5q1o908Vsjx0aW6JkpPyuC0XzHkiEmu+6kRl2 rOQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773601143; x=1774205943; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PgdaL/zWdNdjo2VBs5fMH7nzqTNFHOZ8Z5QsCp8ugaU=; b=oFqOkDeHIdcvwWbiakcnkKc4FP8Hg02/LHMfPp5sNmj4a/6ZJktqVGK3dql2XGmXex qOkSUiokWC5thvAm75nG/imODu2Fy+MUbeLNTBLVE9Rtlg7RE+L+4QtreI623M+EA+6K GJystQAQJMUelIDjaTGcrmXnbcnb8WmGyecbNCCKTR+JEBl2IbmE+ecOx9rI2sv1Pw2u +p9yjpzH2jfKwdRvEa952Og1ODGVUDAFY3So/aJbJcwM1nr1FOWi2h8nSp7sDNqjGOGD FmNLIiZbu1Xyr13b6geN0GwKq9KaGR7aYTbBbCnbfsg0d5n6a5zYDDVqU13zOBPd2LBd w1TA== X-Forwarded-Encrypted: i=1; AJvYcCX314o+uVeE/L30vxG6UnPHCorWp3l5/lbUmr0bsnVuRpFdR7k7zAAX11pXnPCdpWt3gb0F2H1ZaCClOJw=@vger.kernel.org X-Gm-Message-State: AOJu0YwskM+Uo+g4zgg3Ja21wuTLJdagQUTqSUO/oWJzORm5bHU5n2et bc1Hd6IjFjzZYFGVksvcos7mcWJAFNpZIp6iP9ltmF1mjnNkOWhYLe7l X-Gm-Gg: ATEYQzxuMIWHufNcwwM1ELvQSHP69El4SKJSQ0G+Z+TQZws6ezjb5SIB0HpA97lTRbV y5qoNv9J1W6/+PtmR76fuJr+GFs+zI4fBzRkM5lyHvisA5TCS0jzTmFox2IP12norkFnV8p5D6m Xfajkfl/0uc9vfjtt+Q5Tio20zZLxPDK9tys6gUAktWcmtExpzPdmy2YJ0kuuaJovcJJs5S39Pt V+P7xEdaVjGCRE1TMgovwsEWKRjpq1ka8hItSiVpyf+G5Jqq4EeyOqahbL5XMaEHq6YVt+DqMCN us2CADVT3pyUtlENMv6eEf82CsjqD0prKoR8HDLMoJUw1QKffu+ldeUX8Js7Avg5yHVpOQtp8Fr nTrZuB8mOToyCaWxgQ81+ITUmh28Hcr1p1FpJb4AHBM98dhhcMMCZsdEY9oJa48YMDBICHDQME7 x+QUV2MfkECFfsNpp3NImTkTd4HBBr+bXjdw4J2+5TMOzFKuEhx3fy1Y98ZQPyWVHc6oejtD3m1 PwlT5rQwA8UdMpOh9nZMkIZVvFH0QNSS3c84hZt+rxQ X-Received: by 2002:a05:6000:420c:b0:439:ac98:751f with SMTP id ffacd0b85a97d-43a04d8ccbbmr19102903f8f.23.1773601143043; Sun, 15 Mar 2026 11:59:03 -0700 (PDT) Received: from fedora ([46.248.82.114]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439fe1a76e5sm34881965f8f.12.2026.03.15.11.59.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Mar 2026 11:59:02 -0700 (PDT) From: Uros Bizjak To: x86@kernel.org, linux-kernel@vger.kernel.org Cc: Uros Bizjak , "Peter Zijlstra (Intel)" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" Subject: [PATCH -tip v4 1/4] x86/fsgsbase: Remove unnecessary "memory" clobbers from FS/GS base accessors Date: Sun, 15 Mar 2026 19:51:42 +0100 Message-ID: <20260315185248.16615-1-ubizjak@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The rdfsbase() and rdgsbase() helpers currently include a "memory" clobber in their inline assembly definitions. However, the RDFSBASE and RDGSBASE instructions only read the FS/GS base MSRs into a general-purpose register and do not access memory. The "memory" clobber, which acts as a compiler barrier and may inhibit optimization, is therefore unnecessary. The "memory" clobber was historically used as a scheduling constraint to prevent the compiler from moving the instructions before preceding segment register loads. This is not required because both the segment register loads and the RDFSBASE/RDGSBASE accessors are implemented with `asm volatile`, which already prevents reordering between them. No functional change intended. Signed-off-by: Uros Bizjak Acked-by: "Peter Zijlstra (Intel)" Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: Dave Hansen Cc: "H. Peter Anvin" --- v2: Note that the "memory" clobber was historically used as a scheduling constraint. --- arch/x86/include/asm/fsgsbase.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/include/asm/fsgsbase.h b/arch/x86/include/asm/fsgsbase.h index ab2547f97c2c..70ff4ef457b1 100644 --- a/arch/x86/include/asm/fsgsbase.h +++ b/arch/x86/include/asm/fsgsbase.h @@ -25,7 +25,7 @@ static __always_inline unsigned long rdfsbase(void) { unsigned long fsbase; - asm volatile("rdfsbase %0" : "=r" (fsbase) :: "memory"); + asm volatile("rdfsbase %0" : "=r" (fsbase)); return fsbase; } @@ -34,7 +34,7 @@ static __always_inline unsigned long rdgsbase(void) { unsigned long gsbase; - asm volatile("rdgsbase %0" : "=r" (gsbase) :: "memory"); + asm volatile("rdgsbase %0" : "=r" (gsbase)); return gsbase; } -- 2.53.0