From: Atharva Tiwari <atharvatiwarilinuxdev@gmail.com>
Cc: "Atharva Tiwari" <atharvatiwarilinuxdev@gmail.com>,
"Ard Biesheuvel" <ardb@kernel.org>,
"Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
linux-kernel@vger.kernel.org (open list),
linux-efi@vger.kernel.org (open list:EXTENSIBLE FIRMWARE
INTERFACE (EFI)),
platform-driver-x86@vger.kernel.org (open list:X86 PLATFORM
DRIVERS)
Subject: [PATCH v3 2/2] platform/apple-gmux: use apple_brightness to save brightness to EFI
Date: Mon, 16 Mar 2026 03:50:00 +0530 [thread overview]
Message-ID: <20260315222020.24341-3-atharvatiwarilinuxdev@gmail.com> (raw)
In-Reply-To: <20260315222020.24341-1-atharvatiwarilinuxdev@gmail.com>
use apple_brightness to save brightness to EFI.
(tested on iMac20,1)
Signed-off-by: Atharva Tiwari <atharvatiwarilinuxdev@gmail.com>
---
drivers/platform/x86/apple-gmux.c | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/drivers/platform/x86/apple-gmux.c b/drivers/platform/x86/apple-gmux.c
index 1417e230edbd..3797a0e7ff40 100644
--- a/drivers/platform/x86/apple-gmux.c
+++ b/drivers/platform/x86/apple-gmux.c
@@ -22,6 +22,7 @@
#include <linux/pci.h>
#include <linux/vga_switcheroo.h>
#include <linux/debugfs.h>
+#include <linux/platform_data/apple-brightness.h>
#include <acpi/video.h>
#include <asm/io.h>
@@ -78,6 +79,8 @@ struct apple_gmux_data {
/* debugfs data */
u8 selected_port;
struct dentry *debug_dentry;
+
+ bool save_efi;
};
static struct apple_gmux_data *apple_gmux_data;
@@ -960,6 +963,13 @@ static int gmux_probe(struct pnp_dev *pnp, const struct pnp_device_id *id)
}
gmux_init_debugfs(gmux_data);
+ if (IS_ENABLED(CONFIG_APPLE_BRIGHTNESS)) {
+ ret = apple_brightness_probe(gmux_data->bdev, &gmux_get_brightness);
+ if (ret)
+ pr_warn("Unable to Enable EFI brightness save: %d\n", ret);
+ else
+ gmux_data->save_efi = true;
+ }
return 0;
err_register_handler:
@@ -1012,6 +1022,16 @@ static void gmux_remove(struct pnp_dev *pnp)
kfree(gmux_data);
}
+static void gmux_shutdown(struct pnp_dev *pnp)
+{
+ struct apple_gmux_data *gmux_data = pnp_get_drvdata(pnp);
+
+ if (gmux_data->save_efi)
+ apple_brightness_shutdown();
+
+ gmux_remove(pnp);
+}
+
static const struct pnp_device_id gmux_device_ids[] = {
{GMUX_ACPI_HID, 0},
{"", 0}
@@ -1026,6 +1046,7 @@ static struct pnp_driver gmux_pnp_driver = {
.name = "apple-gmux",
.probe = gmux_probe,
.remove = gmux_remove,
+ .shutdown = gmux_shutdown,
.id_table = gmux_device_ids,
.driver = {
.pm = &gmux_dev_pm_ops,
--
2.43.0
next prev parent reply other threads:[~2026-03-15 22:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-15 22:19 [PATCH v3 0/2] Save Brightness on Macs Atharva Tiwari
2026-03-15 22:19 ` [PATCH v3 1/2] efi: Save Brightness using EFI " Atharva Tiwari
2026-03-15 22:47 ` Randy Dunlap
2026-03-15 22:20 ` Atharva Tiwari [this message]
2026-03-16 10:16 ` [PATCH v3 2/2] platform/apple-gmux: use apple_brightness to save brightness to EFI kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260315222020.24341-3-atharvatiwarilinuxdev@gmail.com \
--to=atharvatiwarilinuxdev@gmail.com \
--cc=ardb@kernel.org \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.