Re: [PATCH] blk-wbt: remove WARN_ON_ONCE from wbt_init_enable_default()

[Yuto Ohnuki <ytohnuki@amazon.com>]

On Mon, Mar 16, 2026 at 01:03:17AM +0800, Yu Kuai wrote:
> Can you also add a warning message that disk failed to enable wbt?
> 
> Otherwise this patch looks good to me.

Hi Kuai,

Thanks for the review. That makes sense, and I'll add a pr_warn()
for the wbt_init() failure path.

For wbt_alloc(), I kept it silent since its failure can be caused
by e.g. memory pressure, which doesn't require diagnostic
information.

If I'm missing your point, please let me know.

I'll send a v2. Thanks again.

Yuto



Amazon Web Services EMEA SARL, 38 avenue John F. Kennedy, L-1855 Luxembourg, R.C.S. Luxembourg B186284

Amazon Web Services EMEA SARL, Irish Branch, One Burlington Plaza, Burlington Road, Dublin 4, Ireland, branch registration number 908705