From: Zqiang <qiang.zhang@linux.dev>
To: tytso@mit.edu, adilger.kernel@dilger.ca
Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
qiang.zhang@linux.dev
Subject: [PATCH] ext4: Fix possible NULL pointer dereference in ext4_group_desc_free()
Date: Mon, 16 Mar 2026 16:20:25 +0800 [thread overview]
Message-ID: <20260316082025.9574-1-qiang.zhang@linux.dev> (raw)
This can happen if the kvmalloc_objs() fails and sbi->s_group_desc pointer
is NULL in the ext4_group_desc_init(), and then the ext4_group_desc_free()
is called, leading to a NULL group_desc pointer dereference.
This commit therefore adds a NULL check for sbi->s_group_desc before
accessing its internal members.
Signed-off-by: Zqiang <qiang.zhang@linux.dev>
---
fs/ext4/super.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 43f680c750ae..c4307dc04687 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -1256,9 +1256,11 @@ static void ext4_group_desc_free(struct ext4_sb_info *sbi)
rcu_read_lock();
group_desc = rcu_dereference(sbi->s_group_desc);
- for (i = 0; i < sbi->s_gdb_count; i++)
- brelse(group_desc[i]);
- kvfree(group_desc);
+ if (group_desc) {
+ for (i = 0; i < sbi->s_gdb_count; i++)
+ brelse(group_desc[i]);
+ kvfree(group_desc);
+ }
rcu_read_unlock();
}
--
2.17.1
next reply other threads:[~2026-03-16 8:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 8:20 Zqiang [this message]
2026-03-16 15:49 ` [PATCH] ext4: Fix possible NULL pointer dereference in ext4_group_desc_free() Baokun Li
2026-03-16 23:33 ` Zqiang
2026-03-17 6:32 ` Baokun Li
2026-03-17 13:23 ` Zqiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260316082025.9574-1-qiang.zhang@linux.dev \
--to=qiang.zhang@linux.dev \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.