From: Christoph Hellwig <hch@lst.de>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: linux-xfs@vger.kernel.org, Carlos Maiolino <cem@kernel.org>,
Christoph Hellwig <hch@lst.de>,
Hans Holmberg <hans.holmberg@wdc.com>
Subject: Re: [PATCH 1/3] xfs: improve xfs_select_zone_nowait()
Date: Mon, 16 Mar 2026 10:01:51 +0100 [thread overview]
Message-ID: <20260316090151.GA1952@lst.de> (raw)
In-Reply-To: <20260314235508.183984-2-dlemoal@kernel.org>
On Sun, Mar 15, 2026 at 08:55:06AM +0900, Damien Le Moal wrote:
> Move the check for the return value of the call to
> xfs_select_open_zone_mru() inside the if that controls the call to this
> function, so that we do not uselessly test again the value of oz when
> pack_tight is false.
>
> While at it, also fix a comment typo.
>
> No functional changes.
'improve' is a bit of an odd descriptions as it's wage and subjective.
Maybe try to describe what you're doing a bit better, and to do so
split the patch into the separate parts (even if the one liner
spelling fix is a bit silly otherwise).
The actual functional changes looks good, though.
next prev parent reply other threads:[~2026-03-16 9:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-14 23:55 [PATCH 0/3] Zoned XFS code improvements Damien Le Moal
2026-03-14 23:55 ` [PATCH 1/3] xfs: improve xfs_select_zone_nowait() Damien Le Moal
2026-03-16 9:01 ` Christoph Hellwig [this message]
2026-03-14 23:55 ` [PATCH 2/3] xfs: improve xfs_zoned_show_stats() Damien Le Moal
2026-03-16 9:02 ` Christoph Hellwig
2026-03-14 23:55 ` [PATCH 3/3] xfs: improve xfs_zoned_need_gc() Damien Le Moal
2026-03-16 9:03 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260316090151.GA1952@lst.de \
--to=hch@lst.de \
--cc=cem@kernel.org \
--cc=dlemoal@kernel.org \
--cc=hans.holmberg@wdc.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.