From: Jakub Kicinski <kuba@kernel.org>
To: "Théo Lebrun" <theo.lebrun@bootlin.com>
Cc: "Nicolas Ferre" <nicolas.ferre@microchip.com>,
"Claudiu Beznea" <claudiu.beznea@tuxon.dev>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"Vladimir Kondratiev" <vladimir.kondratiev@mobileye.com>,
"Gregory CLEMENT" <gregory.clement@bootlin.com>,
"Benoît Monin" <benoit.monin@bootlin.com>,
"Tawfik Bayouk" <tawfik.bayouk@mobileye.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Paolo Valerio" <pvalerio@redhat.com>
Subject: Re: [PATCH net-next v2 1/2] net: macb: implement ethtool_ops.get|set_channels()
Date: Mon, 16 Mar 2026 16:20:13 -0700 [thread overview]
Message-ID: <20260316162013.5f8aa0c1@kernel.org> (raw)
In-Reply-To: <DH4CGZWQLUX0.17P120CM20SV8@bootlin.com>
On Mon, 16 Mar 2026 17:24:28 +0100 Théo Lebrun wrote:
> > Sorry for the delay. This code can only be reached from the IOCTL path.
> > The Netlink path will check that params haven't changed in
> > ethnl_set_channels() (look at the @mod variable) and return 0 directly.
> > So you're basically adding a discrepancy between ioctl and Netlink.
> > Not a huge deal but I don't envy any user having to debug this..
>
> Actually, the IOCTL path also does the check (see below). So the
> `count == old_count` check shall be dropped from the driver
> .set_channels() callback because it is redundant. Agreed?
Oh, even better! Some of the ioctl paths don't validate the equivalence
of the config but clearly I don't remember which.
next prev parent reply other threads:[~2026-03-16 23:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 16:41 [PATCH net-next v2 0/2] net: macb: implement ethtool set channels count operation Théo Lebrun
2026-03-11 16:41 ` [PATCH net-next v2 1/2] net: macb: implement ethtool_ops.get|set_channels() Théo Lebrun
2026-03-13 1:26 ` Jakub Kicinski
2026-03-13 15:14 ` Théo Lebrun
2026-03-14 14:54 ` Jakub Kicinski
2026-03-16 16:24 ` Théo Lebrun
2026-03-16 23:20 ` Jakub Kicinski [this message]
2026-03-11 16:41 ` [PATCH net-next v2 2/2] net: macb: distribute evenly Tx SRAM segments Théo Lebrun
2026-03-13 1:30 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260316162013.5f8aa0c1@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=benoit.monin@bootlin.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregory.clement@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=pabeni@redhat.com \
--cc=pvalerio@redhat.com \
--cc=tawfik.bayouk@mobileye.com \
--cc=theo.lebrun@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.kondratiev@mobileye.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.