All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Boris Burkov <boris@bur.io>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com, hch@lst.de,
	sbehrens@giantdisaster.de
Subject: Re: [PATCH] btrfs: btrfs_log_dev_io_error() on all bio errors
Date: Mon, 16 Mar 2026 17:20:20 +0100	[thread overview]
Message-ID: <20260316162020.GA21157@lst.de> (raw)
In-Reply-To: <d2edb3eda4038ef4f2dbd7b76a33a84e3b4ba32c.1773429838.git.boris@bur.io>

On Fri, Mar 13, 2026 at 12:26:05PM -0700, Boris Burkov wrote:
> As far as I can tell, we never intentionally constrained ourselves to
> these status codes, and it is misleading and surprising to lack the
> bdev error logging when we get a different error code from the block
> layer. This can lead to jumping to a wrong conclusion like "this
> system didn't see any bio failures but aborted with EIO".
> 
> For example on nvme devices, I observe many failures coming back as
> BLK_STS_MEDIUM. It is apparent that the nvme driver returns a variety of
> BLK_STS_* status values in nvme_error_status().

This goes all the way back to adding the error counts in commit
442a4f6308e69.  The block error values are a bit of a mess and it's
on my todo list to sort them out - only a small number of them should
even be seen here.  I'd suggest to leave things as-is for now, and
I'll make sure you're included in the discussion when I get around
to attack the block status vs file system issues, which will hopefully
be very soon.


  parent reply	other threads:[~2026-03-16 16:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-13 19:26 [PATCH] btrfs: btrfs_log_dev_io_error() on all bio errors Boris Burkov
2026-03-13 21:18 ` Qu Wenruo
2026-03-16 16:20 ` Christoph Hellwig [this message]
2026-03-16 16:29   ` Boris Burkov
2026-03-17 13:59     ` Christoph Hellwig
2026-03-17 16:16       ` David Sterba
2026-03-27 10:22     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260316162020.GA21157@lst.de \
    --to=hch@lst.de \
    --cc=boris@bur.io \
    --cc=kernel-team@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=sbehrens@giantdisaster.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.