From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C24EEF53D70 for ; Mon, 16 Mar 2026 16:34:33 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 31EAC10E205; Mon, 16 Mar 2026 16:34:33 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="G/cbQ2Lu"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7691610E205 for ; Mon, 16 Mar 2026 16:34:32 +0000 (UTC) Received: from killaraus.ideasonboard.com (2001-14ba-703d-e500--2a1.rev.dnainternet.fi [IPv6:2001:14ba:703d:e500::2a1]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id F34F0BD2; Mon, 16 Mar 2026 17:33:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1773678800; bh=PsYgSXQGk8BFCayvk58j+THY+BZLAGCU8qiWICk6vbs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=G/cbQ2LuTQvse07oW6Z0/uu+igZEbOgAF6vC/IWsuBxo0CpIIEtaiz/HG7dirG7kU glemvrM9xcJdEvZCTdvdc9m0c+vFJ8iEDzktgEWg+Nb3a2ZlrL4qedD7R62vLp1S66 rLMJUvIT+O9V0x8SY+C/RVzho174FI7b1a4AWLAg= Date: Mon, 16 Mar 2026 18:34:25 +0200 From: Laurent Pinchart To: Maxime Ripard Cc: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Jonathan Corbet , Shuah Khan , Dmitry Baryshkov , Jyri Sarha , Tomi Valkeinen , Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 10/14] drm/atomic: Drop private obj state allocation Message-ID: <20260316163425.GO31604@killaraus.ideasonboard.com> References: <20260310-drm-mode-config-init-v1-0-de7397c8e1cf@kernel.org> <20260310-drm-mode-config-init-v1-10-de7397c8e1cf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260310-drm-mode-config-init-v1-10-de7397c8e1cf@kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Mar 10, 2026 at 05:07:02PM +0100, Maxime Ripard wrote: > Now that drm_dev_register() calls drm_mode_config_create_state() for > every modeset driver, the private obj states will be initialized at > driver registration automatically if they haven't already. > > Thus, the explicit initial allocation we have in > drm_atomic_private_obj_init() is now redundant, and we can remove it. > > Signed-off-by: Maxime Ripard Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/drm_atomic.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c > index d1885f895cce78725419b6291f4dbe5563e3b240..e8dc019364d27123c3a682a10323fba9ff76f9df 100644 > --- a/drivers/gpu/drm/drm_atomic.c > +++ b/drivers/gpu/drm/drm_atomic.c > @@ -991,25 +991,18 @@ static void drm_atomic_plane_print_state(struct drm_printer *p, > */ > int drm_atomic_private_obj_init(struct drm_device *dev, > struct drm_private_obj *obj, > const struct drm_private_state_funcs *funcs) > { > - struct drm_private_state *state; > memset(obj, 0, sizeof(*obj)); > > drm_modeset_lock_init(&obj->lock); > > obj->dev = dev; > obj->funcs = funcs; > list_add_tail(&obj->head, &dev->mode_config.privobj_list); > > - state = obj->funcs->atomic_create_state(obj); > - if (IS_ERR(state)) > - return PTR_ERR(state); > - > - obj->state = state; > - > return 0; > } > EXPORT_SYMBOL(drm_atomic_private_obj_init); > > /** > -- Regards, Laurent Pinchart