From: Sami Tolvanen <samitolvanen@google.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
Luis Chamberlain <mcgrof@kernel.org>,
Petr Pavlu <petr.pavlu@suse.com>,
Daniel Gomez <da.gomez@kernel.org>,
Aaron Tomlin <atomlin@atomlin.com>,
Shyam Saini <shyamsaini@linux.microsoft.com>,
Kees Cook <kees@kernel.org>,
Thorsten Blum <thorsten.blum@linux.dev>
Subject: Re: [PATCH] module: remove MODULE_VERSION()
Date: Mon, 16 Mar 2026 17:25:21 +0000 [thread overview]
Message-ID: <20260316172521.GA1300047@google.com> (raw)
In-Reply-To: <abfGQUxgm8mEWlAz@infradead.org>
On Mon, Mar 16, 2026 at 01:58:41AM -0700, Christoph Hellwig wrote:
> On Sat, Mar 14, 2026 at 11:22:22AM +0100, Christophe Leroy (CS GROUP) wrote:
> > > Sami just pointed out to me off-list that maybe I should also drop the
> > > srcversion stuff too. I'll gladly do that too, does anyone know if
> > > anyone even uses that anymore?
> >
> > If I understand correctly the text in kernel/module/Kconfig, srcversion is
> > added only for modules which contain a MODULE_VERSION.
> >
> > So as you drop MODULE_VERSION, srcversion becomes completely useless doesn't
> > it ?
>
> Looks like it.
Looking at modpost, srcversions are added to all modules if
MODULE_SRCVERSION_ALL is enabled, whether they have MODULE_VERSION or
not. Doesn't mean it's not completely useless, of course.
Sami
next prev parent reply other threads:[~2026-03-16 17:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-13 14:20 [PATCH] module: remove MODULE_VERSION() Greg Kroah-Hartman
2026-03-13 15:46 ` Greg Kroah-Hartman
2026-03-13 17:28 ` Sami Tolvanen
2026-03-14 10:22 ` Christophe Leroy (CS GROUP)
2026-03-16 8:58 ` Christoph Hellwig
2026-03-16 17:25 ` Sami Tolvanen [this message]
2026-03-16 10:48 ` Petr Pavlu
2026-03-13 17:07 ` Sami Tolvanen
2026-03-16 8:57 ` Christoph Hellwig
2026-03-16 9:37 ` Petr Pavlu
2026-03-16 10:03 ` Greg Kroah-Hartman
2026-03-17 12:50 ` Petr Pavlu
2026-03-27 12:27 ` Nam Cao
2026-03-27 12:44 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260316172521.GA1300047@google.com \
--to=samitolvanen@google.com \
--cc=atomlin@atomlin.com \
--cc=chleroy@kernel.org \
--cc=da.gomez@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=petr.pavlu@suse.com \
--cc=shyamsaini@linux.microsoft.com \
--cc=thorsten.blum@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.