From: Jakub Kicinski <kuba@kernel.org>
To: Birger Koblitz <mail@birger-koblitz.de>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
linux-usb@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 6/9] r8152: Add support for chip version RTL_VER_16
Date: Mon, 16 Mar 2026 17:50:57 -0700 [thread overview]
Message-ID: <20260316175057.7eed3fab@kernel.org> (raw)
In-Reply-To: <20260314-rtl8157_next-v1-6-9ba77b428afd@birger-koblitz.de>
On Sat, 14 Mar 2026 10:31:42 +0100 Birger Koblitz wrote:
> The RTL8157 uses RTL_VER_16. Add support for this version in all
> remaining configuration functions for power management and RX/TX
> configuration.
../drivers/net/usb/r8152.c:1744:6: warning: variable 'ret' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
1744 | if (i == 10)
| ^~~~~~~
../drivers/net/usb/r8152.c:1747:9: note: uninitialized use occurs here
1747 | return ret;
| ^~~
../drivers/net/usb/r8152.c:1744:2: note: remove the 'if' if its condition is always true
1744 | if (i == 10)
| ^~~~~~~~~~~~
1745 | ret = -ETIMEDOUT;
../drivers/net/usb/r8152.c:1734:12: note: initialize the variable 'ret' to silence this warning
1734 | int i, ret;
| ^
| = 0
next prev parent reply other threads:[~2026-03-17 0:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-14 9:31 [PATCH net-next 0/9] r8152: Add support for the RTL8157 5Gbit USB Ethernet chip Birger Koblitz
2026-03-14 9:31 ` [PATCH net-next 1/9] r8152: Add support for RTL8157 RX/TX descriptor format Birger Koblitz
2026-03-17 0:51 ` Jakub Kicinski
2026-03-17 5:04 ` Birger Koblitz
2026-03-17 15:55 ` Jakub Kicinski
2026-03-17 17:18 ` Birger Koblitz
2026-03-14 9:31 ` [PATCH net-next 2/9] r8152: Add support for RTL8157 SRAM access and ADV indirect access Birger Koblitz
2026-03-17 0:52 ` Jakub Kicinski
2026-03-17 5:10 ` Birger Koblitz
2026-04-10 5:17 ` kernel test robot
2026-04-10 6:11 ` Birger Koblitz
2026-03-14 9:31 ` [PATCH net-next 3/9] r8152: Add support for configuring the PHY of the RTL8157 Birger Koblitz
2026-03-14 9:31 ` [PATCH net-next 4/9] r8152: Add RTL8157 initialization Birger Koblitz
2026-03-14 9:31 ` [PATCH net-next 5/9] r8152: Add RTL8157 startup Birger Koblitz
2026-03-14 9:31 ` [PATCH net-next 6/9] r8152: Add support for chip version RTL_VER_16 Birger Koblitz
2026-03-17 0:50 ` Jakub Kicinski [this message]
2026-03-17 4:35 ` Birger Koblitz
2026-03-14 9:31 ` [PATCH net-next 7/9] r8152: Add support for 5Gbit Link Speeds Birger Koblitz
2026-03-14 9:31 ` [PATCH net-next 8/9] r8152: Add support for 5GBit EEE Birger Koblitz
2026-03-14 9:31 ` [PATCH net-next 9/9] r8152: Detect RTL8157 and setup Birger Koblitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260316175057.7eed3fab@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mail@birger-koblitz.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.