From: Jakub Kicinski <kuba@kernel.org>
To: Ioana Ciornei <ioana.ciornei@nxp.com>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>,
Simon Horman <horms@kernel.org>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next v2 3/3] net: dpaa2-mac: export standard statistics
Date: Mon, 16 Mar 2026 20:42:38 -0700 [thread overview]
Message-ID: <20260316204238.6017858d@kernel.org> (raw)
In-Reply-To: <20260312142249.297192-4-ioana.ciornei@nxp.com>
On Thu, 12 Mar 2026 16:22:49 +0200 Ioana Ciornei wrote:
> + dpaa2_mac_get_standard_stats(mac, &mac->rmon_stats, DPAA2_MAC_NUM_RMON_STATS,
> + dpaa2_mac_rmon_stats, s);
> +
> + *ranges = dpaa2_mac_rmon_ranges;
> +}
> +
> +void dpaa2_mac_get_pause_stats(struct dpaa2_mac *mac, struct ethtool_pause_stats *s)
> +{
> + if (s->src != ETHTOOL_MAC_STATS_SRC_AGGREGATE)
> + return;
> +
> + dpaa2_mac_get_standard_stats(mac, &mac->pause_stats, DPAA2_MAC_NUM_PAUSE_STATS,
> + dpaa2_mac_pause_stats, s);
> +}
> +
> +void dpaa2_mac_get_ctrl_stats(struct dpaa2_mac *mac, struct ethtool_eth_ctrl_stats *s)
> +{
> + if (s->src != ETHTOOL_MAC_STATS_SRC_AGGREGATE)
> + return;
> +
> + dpaa2_mac_get_standard_stats(mac, &mac->eth_ctrl_stats, DPAA2_MAC_NUM_ETH_CTRL_STATS,
> + dpaa2_mac_eth_ctrl_stats, s);
> +}
> +
> +void dpaa2_mac_get_eth_mac_stats(struct dpaa2_mac *mac, struct ethtool_eth_mac_stats *s)
> +{
> + if (s->src != ETHTOOL_MAC_STATS_SRC_AGGREGATE)
> + return;
> +
> + dpaa2_mac_get_standard_stats(mac, &mac->eth_mac_stats, DPAA2_MAC_NUM_ETH_MAC_STATS,
> + dpaa2_mac_eth_mac_stats, s);
> +}
these lines really want to be wrapped at 80
prev parent reply other threads:[~2026-03-17 3:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 14:22 [PATCH net-next v2 0/3] net: dpaa2-mac: export standard statistics Ioana Ciornei
2026-03-12 14:22 ` [PATCH net-next v2 1/3] net: dpaa2-mac: extend APIs related to statistics Ioana Ciornei
2026-03-17 3:39 ` Jakub Kicinski
2026-03-17 8:17 ` Ioana Ciornei
2026-03-12 14:22 ` [PATCH net-next v2 2/3] net: dpaa2-mac: retrieve MAC statistics in one firmware command Ioana Ciornei
2026-03-17 3:41 ` Jakub Kicinski
2026-03-17 8:21 ` Ioana Ciornei
2026-03-12 14:22 ` [PATCH net-next v2 3/3] net: dpaa2-mac: export standard statistics Ioana Ciornei
2026-03-17 3:42 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260316204238.6017858d@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=ioana.ciornei@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.