All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Sieron <michalwsieron@gmail.com>
To: openembedded-core@lists.openembedded.org
Cc: Michal Sieron <michalwsieron@gmail.com>
Subject: [PATCH v2 05/12] no-gplv3.inc: Convert confusing appends to override syntax
Date: Tue, 17 Mar 2026 01:03:09 +0100	[thread overview]
Message-ID: <20260317-fix-invalid-appends-v2-5-5c65ae5787d9@gmail.com> (raw)
In-Reply-To: <20260317-fix-invalid-appends-v2-0-5c65ae5787d9@gmail.com>

While in this case `CORE_IMAGE_EXTRA_INSTALL::pn-* +=` wouldn't result
in any unwanted override, there is no guarantee there won't be a change,
which would be hidden by this override. To avoid any surprises in the
future let's use `:append:pn-* =` syntax here.

Signed-off-by: Michal Sieron <michalwsieron@gmail.com>
---
 meta/conf/distro/include/no-gplv3.inc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/conf/distro/include/no-gplv3.inc b/meta/conf/distro/include/no-gplv3.inc
index 705e05319a..2034204035 100644
--- a/meta/conf/distro/include/no-gplv3.inc
+++ b/meta/conf/distro/include/no-gplv3.inc
@@ -18,9 +18,9 @@ PACKAGECONFIG:remove:pn-bluez5 = "readline"
 # dnf pulls in gpg which is gpl3; it also pulls in python3-rpm which pulls in rpm-build which pulls in bash
 # so install rpm but not dnf
 IMAGE_FEATURES:remove:pn-core-image-weston = "package-management"
-CORE_IMAGE_EXTRA_INSTALL:pn-core-image-weston += "rpm"
+CORE_IMAGE_EXTRA_INSTALL:append:pn-core-image-weston = " rpm"
 IMAGE_FEATURES:remove:pn-core-image-full-cmdline = "package-management"
-CORE_IMAGE_EXTRA_INSTALL:pn-core-image-full-cmdline += "rpm"
+CORE_IMAGE_EXTRA_INSTALL:append:pn-core-image-full-cmdline = " rpm"
 
 # matchbox-terminal depends on vte, which is gpl3
 CORE_IMAGE_BASE_INSTALL:remove:pn-core-image-weston = "matchbox-terminal"

-- 
2.53.0



  parent reply	other threads:[~2026-03-17  0:03 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-17  0:03 [PATCH v2 00/12] Confusing and invalid conditional appends Michal Sieron
2026-03-17  0:03 ` [PATCH v2 01/12] libffi: Fix invalid conditional append Michal Sieron
2026-03-17  0:38   ` [OE-core] " Khem Raj
2026-03-17  0:03 ` [PATCH v2 02/12] coreutils: Convert confusing append to override syntax Michal Sieron
2026-03-17  0:03 ` [PATCH v2 03/12] expat: " Michal Sieron
2026-03-17  0:41   ` [OE-core] " Khem Raj
2026-03-17  0:03 ` [PATCH v2 04/12] tune-power[567]: Remove confusing overrides Michal Sieron
2026-03-17  0:03 ` Michal Sieron [this message]
2026-03-17  0:44   ` [OE-core] [PATCH v2 05/12] no-gplv3.inc: Convert confusing appends to override syntax Khem Raj
2026-03-17  0:03 ` [PATCH v2 06/12] bootchart2: " Michal Sieron
2026-03-17  0:03 ` [PATCH v2 07/12] pigz: Convert confusing append " Michal Sieron
2026-03-17  0:03 ` [PATCH v2 08/12] systemtap: " Michal Sieron
2026-03-17  0:03 ` [PATCH v2 09/12] ovmf: " Michal Sieron
2026-03-17  0:03 ` [PATCH v2 10/12] dnf: " Michal Sieron
2026-03-17  0:03 ` [PATCH v2 11/12] qemu: " Michal Sieron
2026-03-17  0:03 ` [PATCH v2 12/12] recipes-devtools/python: Convert confusing appends " Michal Sieron
2026-03-17  0:50 ` [OE-core] [PATCH v2 00/12] Confusing and invalid conditional appends Khem Raj
2026-03-17 19:09   ` Michal Sieron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260317-fix-invalid-appends-v2-5-5c65ae5787d9@gmail.com \
    --to=michalwsieron@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.