From: Jakub Kicinski <kuba@kernel.org>
To: "Björn Töpel" <bjorn@kernel.org>
Cc: Michael Chan <michael.chan@broadcom.com>,
Pavan Chebbi <pavan.chebbi@broadcom.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
Willem de Bruijn <willemb@google.com>,
Shuah Khan <shuah@kernel.org>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net-next v5 1/3] ethtool: Add RSS indirection table resize helpers
Date: Tue, 17 Mar 2026 15:46:36 -0700 [thread overview]
Message-ID: <20260317154636.78964316@kernel.org> (raw)
In-Reply-To: <20260317083339.2811865-2-bjorn@kernel.org>
On Tue, 17 Mar 2026 09:33:34 +0100 Björn Töpel wrote:
> static int
> rss_set_prep_indir(struct net_device *dev, struct genl_info *info,
> struct rss_reply_data *data, struct ethtool_rxfh_param *rxfh,
> - bool *reset, bool *mod)
> + bool *reset, bool *mod, u32 *user_sizep)
> {
> struct netlink_ext_ack *extack = info->extack;
> struct nlattr **tb = info->attrs;
> @@ -685,6 +685,7 @@ rss_set_prep_indir(struct net_device *dev, struct genl_info *info,
> }
>
> *mod |= memcmp(rxfh->indir, data->indir_table, data->indir_size);
> + *user_sizep = user_size;
>
> return 0;
Weak preference for return user_size; instead of output arg, 7th, "p"?
next prev parent reply other threads:[~2026-03-17 22:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 8:33 [PATCH net-next v5 0/3] ethtool: Dynamic RSS context indirection table resizing Björn Töpel
2026-03-17 8:33 ` [PATCH net-next v5 1/3] ethtool: Add RSS indirection table resize helpers Björn Töpel
2026-03-17 22:46 ` Jakub Kicinski [this message]
2026-03-18 9:27 ` Björn Töpel
2026-03-17 8:33 ` [PATCH net-next v5 2/3] bnxt_en: Resize RSS contexts on channel count change Björn Töpel
2026-03-17 22:53 ` Jakub Kicinski
2026-03-18 9:28 ` Björn Töpel
2026-03-17 8:33 ` [PATCH net-next v5 3/3] selftests: rss_drv: Add RSS indirection table resize tests Björn Töpel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260317154636.78964316@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=bjorn@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.