From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Andrey Albershteyn <aalbersh@redhat.com>,
xfs <linux-xfs@vger.kernel.org>,
ravising@redhat.com, leo.lilong@huawei.com
Subject: Re: [PATCH] xfs_repair: don't fail on INCOMPLETE attrs in leaf blocks
Date: Tue, 17 Mar 2026 13:15:50 -0700 [thread overview]
Message-ID: <20260317201550.GI1770774@frogsfrogsfrogs> (raw)
In-Reply-To: <abkbbpJ9sI_SDhfP@infradead.org>
On Tue, Mar 17, 2026 at 02:14:22AM -0700, Christoph Hellwig wrote:
> On Mon, Mar 16, 2026 at 03:50:33PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> >
> > It's far too drastic to delete the entire attr fork because doing that
> > destroys things like security labels. The kernel won't show incomplete
> > attrs so it's not a big deal.
>
> This sounds a bit lax. Incomplete attributes are very much expected
> given how the non-logged attr code works. Maybe reword this a bit to
> not make it sound like we just ignore a problem?
Ok will do.
--D
next prev parent reply other threads:[~2026-03-17 20:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 22:50 [PATCH] xfs_repair: don't fail on INCOMPLETE attrs in leaf blocks Darrick J. Wong
2026-03-17 9:14 ` Christoph Hellwig
2026-03-17 20:15 ` Darrick J. Wong [this message]
2026-03-17 20:50 ` [PATCH v2] " Darrick J. Wong
2026-03-18 5:56 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260317201550.GI1770774@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=aalbersh@redhat.com \
--cc=hch@infradead.org \
--cc=leo.lilong@huawei.com \
--cc=linux-xfs@vger.kernel.org \
--cc=ravising@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.