All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denis@denix.org>
To: a-christidis@ti.com
Cc: reatmon@ti.com, denys@konsulko.com, meta-arago@lists.yoctoproject.org
Subject: Re: [meta-arago][master][PATCH] flutter-samples-material-3-demo: Add --no-pub build option
Date: Tue, 17 Mar 2026 17:05:32 -0400	[thread overview]
Message-ID: <20260317210532.GE11121@denix.org> (raw)
In-Reply-To: <20260317210138.46226-1-a-christidis@ti.com>

On Tue, Mar 17, 2026 at 04:01:38PM -0500, Antonios Christidis via lists.yoctoproject.org wrote:
> From: Antonios Christidis <a-christidis@ti.com>
> 
> Append "--no-pub" option to flutter.
> 
> There is a patch pending upstream, [1]. The maintainer is inactive/on
> vacation.
> 
> The upstream patch modifies a class, there is no clean way to modify
> a class, so I'm editing FLUTTER_BUILD_ARGS which gets consumed by the
> class. The end behavior is the same.
> 
> [1] https://github.com/meta-flutter/meta-flutter/pull/744
> 
> Signed-off-by: Antonios Christidis <a-christidis@ti.com>
> ---
>  check_yocto_rules.json                                        | 1 +
>  .../flutter/flutter-samples-material-3-demo-arago.inc         | 1 +
>  .../flutter/flutter-samples-material-3-demo_%.bbappend        | 4 ++++
>  3 files changed, 6 insertions(+)
>  create mode 100644 meta-arago-test/dynamic-layers/flutter-layer/recipes-graphics/flutter/flutter-samples-material-3-demo-arago.inc
>  create mode 100644 meta-arago-test/dynamic-layers/flutter-layer/recipes-graphics/flutter/flutter-samples-material-3-demo_%.bbappend
> 
> diff --git a/check_yocto_rules.json b/check_yocto_rules.json
> index 25c8c952..70bbe734 100644
> --- a/check_yocto_rules.json
> +++ b/check_yocto_rules.json
> @@ -23,6 +23,7 @@
>              "meta-arago-extras/recipes-extended/sysrepo/libyang_%.bbappend",
>              "meta-arago-test/dynamic-layers/qt6-layer/recipes-core/packagegroups/ti-test.bbappend",
>              "meta-arago-test/dynamic-layers/flutter-layer/recipes-graphics/flutter/flutter-wayland-client_%.bbappend",
> +            "meta-arago-test/dynamic-layers/flutter-layer/recipes-graphics/flutter/flutter-samples-material-3-demo_%.bbappend",
>              "meta-arago-test/recipes-benchmark/stream/stream_%.bbappend",
>              "meta-arago-test/recipes-extended/bc/bc_%.bbappend"
>          ]
> diff --git a/meta-arago-test/dynamic-layers/flutter-layer/recipes-graphics/flutter/flutter-samples-material-3-demo-arago.inc b/meta-arago-test/dynamic-layers/flutter-layer/recipes-graphics/flutter/flutter-samples-material-3-demo-arago.inc
> new file mode 100644
> index 00000000..b2c9e13d
> --- /dev/null
> +++ b/meta-arago-test/dynamic-layers/flutter-layer/recipes-graphics/flutter/flutter-samples-material-3-demo-arago.inc
> @@ -0,0 +1 @@
> +FLUTTER_BUILD_ARGS:append = " --no-pub"

Will it work with += here instead of :append?


> diff --git a/meta-arago-test/dynamic-layers/flutter-layer/recipes-graphics/flutter/flutter-samples-material-3-demo_%.bbappend b/meta-arago-test/dynamic-layers/flutter-layer/recipes-graphics/flutter/flutter-samples-material-3-demo_%.bbappend
> new file mode 100644
> index 00000000..f0ae3799
> --- /dev/null
> +++ b/meta-arago-test/dynamic-layers/flutter-layer/recipes-graphics/flutter/flutter-samples-material-3-demo_%.bbappend
> @@ -0,0 +1,4 @@
> +FLUTTER_ARAGO = ""
> +FLUTTER_ARAGO:arago = "flutter-samples-material-3-demo-arago.inc"
> +
> +require ${FLUTTER_ARAGO}
> -- 
> 2.34.1


  reply	other threads:[~2026-03-17 21:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-17 21:01 [meta-arago][master][PATCH] flutter-samples-material-3-demo: Add --no-pub build option a-christidis
2026-03-17 21:05 ` Denys Dmytriyenko [this message]
2026-03-18 15:59   ` Antonios Christidis
2026-03-18 18:45     ` Denys Dmytriyenko
2026-03-17 21:08 ` PRC Automation

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260317210532.GE11121@denix.org \
    --to=denis@denix.org \
    --cc=a-christidis@ti.com \
    --cc=denys@konsulko.com \
    --cc=meta-arago@lists.yoctoproject.org \
    --cc=reatmon@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.