From: Shuicheng Lin <shuicheng.lin@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Shuicheng Lin <shuicheng.lin@intel.com>,
Nitin Gote <nitin.r.gote@intel.com>
Subject: [PATCH 3/5] drm/xe: Add missing trailing underscore to include guards
Date: Tue, 17 Mar 2026 21:57:19 +0000 [thread overview]
Message-ID: <20260317215732.2208976-10-shuicheng.lin@intel.com> (raw)
In-Reply-To: <20260317215732.2208976-7-shuicheng.lin@intel.com>
Four headers use _XE_<NAME>_H (no trailing underscore) as their include
guard. Normalize them to _XE_<NAME>_H_ to match the dominant convention
used across the xe codebase.
Files fixed:
- xe_guc_capture.h: _XE_GUC_CAPTURE_H -> _XE_GUC_CAPTURE_H_
- xe_guc_capture_types.h: _XE_GUC_CAPTURE_TYPES_H -> _XE_GUC_CAPTURE_TYPES_H_
- xe_guc_fwif.h: _XE_GUC_FWIF_H -> _XE_GUC_FWIF_H_
- xe_uc_fw_abi.h: _XE_UC_FW_ABI_H -> _XE_UC_FW_ABI_H_
No functional change.
Suggested-by: Nitin Gote <nitin.r.gote@intel.com>
Assisted-by: GitHub Copilot:claude-opus-4.6
Signed-off-by: Shuicheng Lin <shuicheng.lin@intel.com>
---
drivers/gpu/drm/xe/xe_guc_capture.h | 4 ++--
drivers/gpu/drm/xe/xe_guc_capture_types.h | 4 ++--
drivers/gpu/drm/xe/xe_guc_fwif.h | 4 ++--
drivers/gpu/drm/xe/xe_uc_fw_abi.h | 4 ++--
4 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_guc_capture.h b/drivers/gpu/drm/xe/xe_guc_capture.h
index 34d6fdc64f56..dca97d52b192 100644
--- a/drivers/gpu/drm/xe/xe_guc_capture.h
+++ b/drivers/gpu/drm/xe/xe_guc_capture.h
@@ -3,8 +3,8 @@
* Copyright © 2021-2024 Intel Corporation
*/
-#ifndef _XE_GUC_CAPTURE_H
-#define _XE_GUC_CAPTURE_H
+#ifndef _XE_GUC_CAPTURE_H_
+#define _XE_GUC_CAPTURE_H_
#include <linux/types.h>
#include "abi/guc_capture_abi.h"
diff --git a/drivers/gpu/drm/xe/xe_guc_capture_types.h b/drivers/gpu/drm/xe/xe_guc_capture_types.h
index 04e9bbe3e20b..058a3f2eadce 100644
--- a/drivers/gpu/drm/xe/xe_guc_capture_types.h
+++ b/drivers/gpu/drm/xe/xe_guc_capture_types.h
@@ -3,8 +3,8 @@
* Copyright © 2021-2024 Intel Corporation
*/
-#ifndef _XE_GUC_CAPTURE_TYPES_H
-#define _XE_GUC_CAPTURE_TYPES_H
+#ifndef _XE_GUC_CAPTURE_TYPES_H_
+#define _XE_GUC_CAPTURE_TYPES_H_
#include <linux/types.h>
#include "regs/xe_reg_defs.h"
diff --git a/drivers/gpu/drm/xe/xe_guc_fwif.h b/drivers/gpu/drm/xe/xe_guc_fwif.h
index bb8f71d38611..72a4b6014465 100644
--- a/drivers/gpu/drm/xe/xe_guc_fwif.h
+++ b/drivers/gpu/drm/xe/xe_guc_fwif.h
@@ -3,8 +3,8 @@
* Copyright © 2022 Intel Corporation
*/
-#ifndef _XE_GUC_FWIF_H
-#define _XE_GUC_FWIF_H
+#ifndef _XE_GUC_FWIF_H_
+#define _XE_GUC_FWIF_H_
#include <linux/bits.h>
diff --git a/drivers/gpu/drm/xe/xe_uc_fw_abi.h b/drivers/gpu/drm/xe/xe_uc_fw_abi.h
index 3c9a63d13032..74b888904fdc 100644
--- a/drivers/gpu/drm/xe/xe_uc_fw_abi.h
+++ b/drivers/gpu/drm/xe/xe_uc_fw_abi.h
@@ -3,8 +3,8 @@
* Copyright © 2022 Intel Corporation
*/
-#ifndef _XE_UC_FW_ABI_H
-#define _XE_UC_FW_ABI_H
+#ifndef _XE_UC_FW_ABI_H_
+#define _XE_UC_FW_ABI_H_
#include <linux/build_bug.h>
#include <linux/types.h>
--
2.43.0
next prev parent reply other threads:[~2026-03-17 22:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 21:57 [PATCH 0/5] drm/xe: Fix mismatched include guards in header files Shuicheng Lin
2026-03-17 21:57 ` [PATCH 1/5] drm/xe: Add missing include guards to unprotected headers Shuicheng Lin
2026-03-30 7:14 ` Gote, Nitin R
2026-03-17 21:57 ` [PATCH 2/5] drm/xe: Add missing _H to include guard suffixes Shuicheng Lin
2026-03-30 7:16 ` Gote, Nitin R
2026-03-17 21:57 ` Shuicheng Lin [this message]
2026-03-30 7:18 ` [PATCH 3/5] drm/xe: Add missing trailing underscore to include guards Gote, Nitin R
2026-03-17 21:57 ` [PATCH 4/5] drm/xe: Add missing leading " Shuicheng Lin
2026-03-30 7:19 ` Gote, Nitin R
2026-03-17 21:57 ` [PATCH 5/5] drm/xe: Normalize double-underscore include guards to single-underscore Shuicheng Lin
2026-03-30 7:21 ` Gote, Nitin R
2026-03-30 8:31 ` Simon Richter
2026-03-30 10:17 ` Jani Nikula
2026-03-31 16:31 ` Lin, Shuicheng
2026-03-17 22:06 ` ✗ CI.checkpatch: warning for drm/xe: Fix mismatched include guards in header files (rev2) Patchwork
2026-03-17 22:08 ` ✓ CI.KUnit: success " Patchwork
2026-03-17 22:51 ` ✓ Xe.CI.BAT: " Patchwork
2026-03-19 9:30 ` ✓ Xe.CI.FULL: " Patchwork
2026-04-06 16:07 ` Lin, Shuicheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260317215732.2208976-10-shuicheng.lin@intel.com \
--to=shuicheng.lin@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=nitin.r.gote@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.