All of lore.kernel.org
 help / color / mirror / Atom feed
From: SeongJae Park <sj@kernel.org>
To: Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: SeongJae Park <sj@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Minchan Kim <minchan@kernel.org>,
	linux-block@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] zram: change scan_slots to return void
Date: Tue, 17 Mar 2026 17:57:04 -0700	[thread overview]
Message-ID: <20260318005705.132331-1-sj@kernel.org> (raw)
In-Reply-To: <20260317032349.753645-1-senozhatsky@chromium.org>

On Tue, 17 Mar 2026 12:23:19 +0900 Sergey Senozhatsky <senozhatsky@chromium.org> wrote:

> scan_slots_for_writeback() and scan_slots_for_recompress()
> work in a "best effort" fashion, if they cannot allocate
> memory for a new pp-slot candidate they just return and
> post-processing selects slots that were successfully
> scanned thus far.  scan_slots functions never return
> errors and their callers never check the return status,
> so convert them to return void.

Makes sense.

> 
> Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org>

Reviewed-by: SeongJae Park <sj@kernel.org>


Thanks,
SJ

[...]

      reply	other threads:[~2026-03-18  0:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-17  3:23 [PATCH] zram: change scan_slots to return void Sergey Senozhatsky
2026-03-18  0:57 ` SeongJae Park [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260318005705.132331-1-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan@kernel.org \
    --cc=senozhatsky@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.