From: Christoph Hellwig <hch@lst.de>
To: Dave Chinner <dgc@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Carlos Maiolino <cem@kernel.org>,
Dave Chinner <dchinner@redhat.com>,
Brian Foster <bfoster@redhat.com>,
linux-xfs@vger.kernel.org, "Darrick J. Wong" <djwong@kernel.org>
Subject: Re: [PATCH 1/4] xfs: don't keep a reference for buffers on the LRU
Date: Wed, 18 Mar 2026 15:38:12 +0100 [thread overview]
Message-ID: <20260318143812.GA21119@lst.de> (raw)
In-Reply-To: <abnIqhTZXZxIb6VS@dread>
On Wed, Mar 18, 2026 at 08:33:30AM +1100, Dave Chinner wrote:
> The jump with the lock held is kinda nasty. The lock scope can be
> straight-lined by inverting the logic like so:
The current code keeps things most straight by keeping all the
non-default code in a barnch. The above with more unlocks in
multiple branches feels a lot harder to follow.
next prev parent reply other threads:[~2026-03-18 14:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 13:40 buffer cache simplification v5 Christoph Hellwig
2026-03-17 13:40 ` [PATCH 1/4] xfs: don't keep a reference for buffers on the LRU Christoph Hellwig
2026-03-17 21:33 ` Dave Chinner
2026-03-18 14:38 ` Christoph Hellwig [this message]
2026-03-18 11:44 ` Brian Foster
2026-03-17 13:40 ` [PATCH 2/4] xfs: use a lockref for the buffer reference count Christoph Hellwig
2026-03-17 21:53 ` Dave Chinner
2026-03-18 14:49 ` Christoph Hellwig
2026-03-17 13:40 ` [PATCH 3/4] xfs: switch (back) to a per-buftarg buffer hash Christoph Hellwig
2026-03-17 22:00 ` Dave Chinner
2026-03-18 12:14 ` Brian Foster
2026-03-17 13:40 ` [PATCH 4/4] xfs: don't decrement the buffer LRU count for in-use buffers Christoph Hellwig
2026-03-17 22:06 ` Dave Chinner
2026-03-18 11:47 ` Brian Foster
2026-03-18 11:45 ` Brian Foster
-- strict thread matches above, loose matches on Subject: below --
2026-03-23 7:50 buffer cache simplification v6 Christoph Hellwig
2026-03-23 7:50 ` [PATCH 1/4] xfs: don't keep a reference for buffers on the LRU Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260318143812.GA21119@lst.de \
--to=hch@lst.de \
--cc=bfoster@redhat.com \
--cc=cem@kernel.org \
--cc=dchinner@redhat.com \
--cc=dgc@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.