All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josh Law <objecting@objecting.org>
To: Masami Hiramatsu <mhiramat@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
	Josh Law <objecting@objecting.org>
Subject: [PATCH v8 09/13] lib/bootconfig: fix signed comparison in xbc_node_get_data()
Date: Wed, 18 Mar 2026 15:59:15 +0000	[thread overview]
Message-ID: <20260318155919.78168-10-objecting@objecting.org> (raw)
In-Reply-To: <20260318155919.78168-1-objecting@objecting.org>

  lib/bootconfig.c:188:28: warning: comparison of integer expressions
  of different signedness: 'int' and 'size_t' [-Wsign-compare]

The local variable 'offset' is declared as int, but xbc_data_size is
size_t.  Change the type to size_t to match and eliminate the warning.

Signed-off-by: Josh Law <objecting@objecting.org>
---
 lib/bootconfig.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/bootconfig.c b/lib/bootconfig.c
index ecc4e8d93547..dd639046912c 100644
--- a/lib/bootconfig.c
+++ b/lib/bootconfig.c
@@ -183,7 +183,7 @@ struct xbc_node * __init xbc_node_get_next(struct xbc_node *node)
  */
 const char * __init xbc_node_get_data(struct xbc_node *node)
 {
-	int offset = node->data & ~XBC_VALUE;
+	size_t offset = node->data & ~XBC_VALUE;
 
 	if (WARN_ON(offset >= xbc_data_size))
 		return NULL;
-- 
2.34.1


  parent reply	other threads:[~2026-03-18 15:59 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-18 15:59 [PATCH v8 00/13] bootconfig: cleanups, correctness, and modernization Josh Law
2026-03-18 15:59 ` [PATCH v8 01/13] lib/bootconfig: clean up comment typos and bracing Josh Law
2026-03-18 15:59 ` [PATCH v8 02/13] lib/bootconfig: narrow flag parameter type from uint32_t to uint16_t Josh Law
2026-03-18 15:59 ` [PATCH v8 03/13] lib/bootconfig: fix off-by-one in xbc_verify_tree() next node check Josh Law
2026-03-18 15:59 ` [PATCH v8 04/13] lib/bootconfig: increment xbc_node_num after node init succeeds Josh Law
2026-03-18 15:59 ` [PATCH v8 05/13] lib/bootconfig: drop redundant memset of xbc_nodes Josh Law
2026-03-18 20:22   ` Markus Elfring
2026-03-18 15:59 ` [PATCH v8 06/13] bootconfig: constify xbc_calc_checksum() data parameter Josh Law
2026-03-18 15:59 ` [PATCH v8 07/13] lib/bootconfig: replace linux/kernel.h with specific includes Josh Law
2026-03-18 15:59 ` [PATCH v8 08/13] lib/bootconfig: validate child node index in xbc_verify_tree() Josh Law
2026-03-18 15:59 ` Josh Law [this message]
2026-03-18 15:59 ` [PATCH v8 10/13] lib/bootconfig: use size_t for strlen result in xbc_node_match_prefix() Josh Law
2026-03-18 15:59 ` [PATCH v8 11/13] lib/bootconfig: use signed type for offset in xbc_init_node() Josh Law
2026-03-18 15:59 ` [PATCH v8 12/13] lib/bootconfig: use size_t for key length tracking in xbc_verify_tree() Josh Law
2026-03-18 15:59 ` [PATCH v8 13/13] lib/bootconfig: change xbc_node_index() return type to uint16_t Josh Law

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260318155919.78168-10-objecting@objecting.org \
    --to=objecting@objecting.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.