From: Jakub Kicinski <kuba@kernel.org>
To: Pin-yen Lin <treapking@google.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>,
Taehee Yoo <ap420073@gmail.com>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
netdev@vger.kernel.org, Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCH net] selftests: drv-net: ping: Wait for carrier after toggling offloads
Date: Wed, 18 Mar 2026 17:28:02 -0700 [thread overview]
Message-ID: <20260318172802.46c1fef1@kernel.org> (raw)
In-Reply-To: <20260318010325.2003395-1-treapking@google.com>
On Tue, 17 Mar 2026 18:01:17 -0700 Pin-yen Lin wrote:
> Toggling checksum offload (or HW-GRO via feature dependencies) can cause
> certain physical interfaces to undergo a reset or a temporary link-down
> state. In the ping.py test, this leads to immediate test failures if the
> ping is attempted before the carrier is restored.
>
> This is observed when running the test with GVE driver when HW-GRO is
> enabled. When checksum offload is toggled, HW-GRO is toggled as well
> because of the feature dependency. This leads to an interface reset,
> causing the subsequent ping to fail.
>
> Add a sleep period after changing these features to allow the link to
> stabilize.
Sounds like the test found a legitimate problem. The configuration
should not return to user space until the operation has completed.
User should not have to sleep 10sec each time they touch NIC
configuration.
--
pw-bot: reject
next prev parent reply other threads:[~2026-03-19 0:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-18 1:01 [PATCH net] selftests: drv-net: ping: Wait for carrier after toggling offloads Pin-yen Lin
2026-03-19 0:28 ` Jakub Kicinski [this message]
2026-03-19 0:51 ` Pin-yen Lin
2026-03-19 1:25 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260318172802.46c1fef1@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=ap420073@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=treapking@google.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.