From: Leon Romanovsky <leon@kernel.org>
To: Konstantin Taranov <kotaranov@linux.microsoft.com>
Cc: kotaranov@microsoft.com, shirazsaleem@microsoft.com,
longli@microsoft.com, jgg@ziepe.ca, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH rdma-next 1/1] RDMA/mana_ib: cleanup the usage of mana_gd_send_request()
Date: Wed, 18 Mar 2026 20:27:12 +0200 [thread overview]
Message-ID: <20260318182712.GI352386@unreal> (raw)
In-Reply-To: <20260318173939.1417856-1-kotaranov@linux.microsoft.com>
On Wed, Mar 18, 2026 at 10:39:39AM -0700, Konstantin Taranov wrote:
> From: Konstantin Taranov <kotaranov@microsoft.com>
>
> Do not check the status of the response header returned by mana_gd_send_request(),
> as the returned error code already indicates the request status.
>
> The mana_gd_send_request() may return no error code and have the response status
> GDMA_STATUS_MORE_ENTRIES, which is a successful completion. It is used
> for checking the correctness of multi-request operations, such as creation of
> a dma region with mana_ib_gd_create_dma_region().
>
> Signed-off-by: Konstantin Taranov <kotaranov@microsoft.com>
> ---
> drivers/infiniband/hw/mana/main.c | 105 ++++--------------------------
> drivers/infiniband/hw/mana/mr.c | 38 ++---------
> drivers/infiniband/hw/mana/qp.c | 9 +--
> 3 files changed, 19 insertions(+), 133 deletions(-)
I fixed coding style errors, removed same debug print from other
mana_gd_send_request() callers, together with netdev prints, which don't
belong to RDMA and applied the patch.
Thanks
prev parent reply other threads:[~2026-03-18 18:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-18 17:39 [PATCH rdma-next 1/1] RDMA/mana_ib: cleanup the usage of mana_gd_send_request() Konstantin Taranov
2026-03-18 18:26 ` Leon Romanovsky
2026-03-18 18:27 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260318182712.GI352386@unreal \
--to=leon@kernel.org \
--cc=jgg@ziepe.ca \
--cc=kotaranov@linux.microsoft.com \
--cc=kotaranov@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=shirazsaleem@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.