Re: [PATCH] staging: rtl8723bs: remove unnecessary braces in single statement blocks

[kernel test robot <lkp@intel.com>]

Hi Oskar,

kernel test robot noticed the following build errors:

[auto build test ERROR on staging/staging-testing]

url:    https://github.com/intel-lab-lkp/linux/commits/Oskar-Ray-Frayssinet/staging-rtl8723bs-remove-unnecessary-braces-in-single-statement-blocks/20260318-121311
base:   staging/staging-testing
patch link:    https://lore.kernel.org/r/20260317203715.7430-1-rayfraytech%40gmail.com
patch subject: [PATCH] staging: rtl8723bs: remove unnecessary braces in single statement blocks
config: nios2-allmodconfig (https://download.01.org/0day-ci/archive/20260318/202603182051.NuXiZYrt-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 11.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260318/202603182051.NuXiZYrt-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603182051.NuXiZYrt-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c: In function 'halbtc8723b2ant_WifiRssiState':
>> drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c:131:25: error: expected '}' before 'else'
     131 |                         else
         |                         ^~~~


vim +131 drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c

    82	
    83	static u8 halbtc8723b2ant_WifiRssiState(
    84		struct btc_coexist *pBtCoexist,
    85		u8 index,
    86		u8 levelNum,
    87		u8 rssiThresh,
    88		u8 rssiThresh1
    89	)
    90	{
    91		s32 wifiRssi = 0;
    92		u8 wifiRssiState = pCoexSta->preWifiRssiState[index];
    93	
    94		pBtCoexist->fBtcGet(pBtCoexist, BTC_GET_S4_WIFI_RSSI, &wifiRssi);
    95	
    96		if (levelNum == 2) {
    97			if (
    98				(pCoexSta->preWifiRssiState[index] == BTC_RSSI_STATE_LOW) ||
    99				(pCoexSta->preWifiRssiState[index] == BTC_RSSI_STATE_STAY_LOW)
   100			) {
   101				if (wifiRssi >= (rssiThresh + BTC_RSSI_COEX_THRESH_TOL_8723B_2ANT))
   102					wifiRssiState = BTC_RSSI_STATE_HIGH;
   103				else
   104					wifiRssiState = BTC_RSSI_STATE_STAY_LOW;
   105			} else {
   106				if (wifiRssi < rssiThresh)
   107					wifiRssiState = BTC_RSSI_STATE_LOW;
   108				else
   109					wifiRssiState = BTC_RSSI_STATE_STAY_HIGH;
   110			}
   111		} else if (levelNum == 3) {
   112			if (rssiThresh > rssiThresh1)
   113				return pCoexSta->preWifiRssiState[index];
   114	
   115			if (
   116				(pCoexSta->preWifiRssiState[index] == BTC_RSSI_STATE_LOW) ||
   117				(pCoexSta->preWifiRssiState[index] == BTC_RSSI_STATE_STAY_LOW)
   118			) {
   119				if (wifiRssi >= (rssiThresh + BTC_RSSI_COEX_THRESH_TOL_8723B_2ANT))
   120					wifiRssiState = BTC_RSSI_STATE_MEDIUM;
   121				else
   122					wifiRssiState = BTC_RSSI_STATE_STAY_LOW;
   123			} else if (
   124				(pCoexSta->preWifiRssiState[index] == BTC_RSSI_STATE_MEDIUM) ||
   125				(pCoexSta->preWifiRssiState[index] == BTC_RSSI_STATE_STAY_MEDIUM)
   126			) {
   127				if (wifiRssi >= (rssiThresh1 + BTC_RSSI_COEX_THRESH_TOL_8723B_2ANT))
   128					wifiRssiState = BTC_RSSI_STATE_HIGH;
   129				else if (wifiRssi < rssiThresh) {
   130					wifiRssiState = BTC_RSSI_STATE_LOW;
 > 131				else
   132					wifiRssiState = BTC_RSSI_STATE_STAY_MEDIUM;
   133			} else {
   134				if (wifiRssi < rssiThresh1)
   135					wifiRssiState = BTC_RSSI_STATE_MEDIUM;
   136				else
   137					wifiRssiState = BTC_RSSI_STATE_STAY_HIGH;
   138			}
   139		}
   140	
   141		pCoexSta->preWifiRssiState[index] = wifiRssiState;
   142	
   143		return wifiRssiState;
   144	}
   145	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki