All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Omer Zalman <omerzalman42@gmail.com>
Cc: oliver@neukum.org, andrew+netdev@lunn.ch, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	linux-usb@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] net: usb: cdc_ncm: convert sysfs show() callbacks to sysfs_emit()
Date: Wed, 18 Mar 2026 07:36:44 +0100	[thread overview]
Message-ID: <2026031824-bladder-percent-ba02@gregkh> (raw)
In-Reply-To: <20260318040632.69531-1-omerzalman42@gmail.com>

On Tue, Mar 17, 2026 at 11:06:31PM -0500, Omer Zalman wrote:
> sysfs_emit() was introduced in v5.10 as the preferred replacement for
> sprintf() in sysfs show() handlers. It bounds output to PAGE_SIZE and
> avoids potential buffer overruns.
> 
> Convert all show() callbacks and the NCM_PARM_ATTR macro from sprintf()
> to sysfs_emit().

There is no need to change existing show functions to sysfs_emit(),
unless you are doing some other work in the same area.  Otherwise it
would be a huge churn all across the tree.

So no need for this patch, sorry.

thanks,

greg k-h

      parent reply	other threads:[~2026-03-18  6:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-18  4:06 [PATCH 1/2] net: usb: cdc_ncm: convert sysfs show() callbacks to sysfs_emit() Omer Zalman
2026-03-18  4:06 ` [PATCH 2/2] net: usb: cdc_ncm: prevent silent u16 truncation in min_tx_pkt_store() Omer Zalman
2026-03-18  6:37   ` Greg KH
2026-03-18  6:36 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026031824-bladder-percent-ba02@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=oliver@neukum.org \
    --cc=omerzalman42@gmail.com \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.