From: Greg KH <gregkh@linuxfoundation.org>
To: Mark Adamenko <marusik.adamenko@gmail.com>
Cc: linux-staging@lists.linux.dev,
parthiban.veerasooran@microchip.com,
christian.gromm@microchip.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: most: dim2: remove BUG_ON() calls
Date: Wed, 18 Mar 2026 16:28:50 +0100 [thread overview]
Message-ID: <2026031825-delicious-capsule-f1bf@gregkh> (raw)
In-Reply-To: <20260310013304.39169-1-marusik.adamenko@gmail.com>
On Mon, Mar 09, 2026 at 06:33:04PM -0700, Mark Adamenko wrote:
> All BUG_ON() calls in this file are redundant either because of
> impossible conditions or prior error handling. Remove all BUG_ON()
> calls.
>
> Signed-off-by: Mark Adamenko <marusik.adamenko@gmail.com>
> ---
> drivers/staging/most/dim2/dim2.c | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c
> index 66617e89e028..c8fdc6a52467 100644
> --- a/drivers/staging/most/dim2/dim2.c
> +++ b/drivers/staging/most/dim2/dim2.c
> @@ -165,9 +165,6 @@ static int try_start_dim_transfer(struct hdm_channel *hdm_ch)
> unsigned long flags;
> struct dim_ch_state st;
>
> - BUG_ON(!hdm_ch);
> - BUG_ON(!hdm_ch->is_initialized);
> -
Please only remove one at a time, and provide the "proof" in the
changelog for why the case can never be hit.
thanks,
greg k-h
prev parent reply other threads:[~2026-03-18 15:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 1:33 [PATCH] staging: most: dim2: remove BUG_ON() calls Mark Adamenko
2026-03-18 15:28 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026031825-delicious-capsule-f1bf@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=christian.gromm@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=marusik.adamenko@gmail.com \
--cc=parthiban.veerasooran@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.