From: Greg KH <gregkh@linuxfoundation.org>
To: Marco Antonio Solis Segura <mshdevv@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: collapse duplicate goto exit conditions
Date: Wed, 18 Mar 2026 16:54:19 +0100 [thread overview]
Message-ID: <2026031855-spoon-uncrown-4090@gregkh> (raw)
In-Reply-To: <20260317135548.239746-1-mshdevv@gmail.com>
On Tue, Mar 17, 2026 at 07:55:48AM -0600, Marco Antonio Solis Segura wrote:
> Combine _FAIL and RTW_RX_HANDLED cases into a single conditional,
> removing redundant branches and simplifying control flow.
> No functional changes intended.
>
> Signed-off-by: Marco Antonio Solis Segura <mshdevv@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_recv.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
> index 337671b1211f..20f5f8760ba0 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_recv.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
> @@ -1339,12 +1339,8 @@ static signed int validate_recv_data_frame(struct adapter *adapter, union recv_f
>
> }
>
> - if (ret == _FAIL) {
> + if (ret == _FAIL || ret == RTW_RX_HANDLED)
> goto exit;
> - } else if (ret == RTW_RX_HANDLED) {
> - goto exit;
> - }
> -
>
> if (!psta) {
> ret = _FAIL;
> --
> 2.53.0
>
>
Someone sent this _right_ before you did:
https://lore.kernel.org/r/20260317100723.72476-1-giacomodiclerico@gmail.com
Are you all working on this together? What project is asking you to
send patches for this driver?
thanks,
greg k-h
next prev parent reply other threads:[~2026-03-18 15:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 13:55 [PATCH] staging: rtl8723bs: collapse duplicate goto exit conditions Marco Antonio Solis Segura
2026-03-18 15:54 ` Greg KH [this message]
2026-03-18 22:51 ` Marco Solis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026031855-spoon-uncrown-4090@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mshdevv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.