From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94B3537E2FB for ; Thu, 19 Mar 2026 09:37:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773913068; cv=none; b=XgiYqN+E4u/uYebQcXgSWoK9ChY/FyjUQuLp2OZGpHZqXu43uDYdJxlCe2ep92dmqAfFSwJWMIJBxJzO3S65mnx/S9vYNYwmeHdsNckAQtZ5gM+059ShXntHq4f5vwjkWx4lWJANcop8WbsF2stDP9fh/aqnsDLGdUMS0Rd6CJY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773913068; c=relaxed/simple; bh=eBub557DpP8SujViBVGJeqHpi8cYm17tMWqr07kjILI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=P04Wk96PrCMred2cKTJ2r7TvfRWuajg/3SDnSbcFcu5tcmaUbomMEll5xp/SBVqS1Gle45G+1NmCVrzdUueXV4+wR4U9Q2P2WE8fqEd6jcd8h9cX944mfQTlDezEdvyjkbCLvYfm+k1HP2ciYXl27M1mPOfTfqh01YSROxd+8LQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=permerror header.from=versity.com; spf=pass smtp.mailfrom=versity.com; dkim=pass (2048-bit key) header.d=versity.com header.i=@versity.com header.b=lV7B39yb; arc=none smtp.client-ip=209.85.218.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=permerror header.from=versity.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=versity.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=versity.com header.i=@versity.com header.b="lV7B39yb" Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-b79f8f7ea43so112316666b.2 for ; Thu, 19 Mar 2026 02:37:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=versity.com; s=google; t=1773913065; x=1774517865; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dNgb6/ySHq+PmuPa2Ob8yekXF7lWjZXA5229XYLgkxs=; b=lV7B39yb/druHygarpzUGXBghnAgJK1tpSSPrG3cXB4+4U0ZBKFplRTFIRjgai1Mhi +tARLb2sbUCvNKVmj4vnEy89PAyQ7NXrBLVsRpvsTsGAJBl7UCWE+Bq/uDSrNCulqZQM p8hT4wwP9Cxd1zO+I/ARuJPEGlusoezOCJJ83oeE03q3kGvVeZ7Q18GFBawuBZfRoPhM GRCXSg+98gka9Cjt6AvJ5ajFyHWSNt0R+vBokW9JyUUjA3Td6nCtZH8KWHDNNuU4oBXz Ih6FtOu+4Icv53Yz/+OPqyP64FeFl14EoC7hVSrMmswermaQPyXqQpo18N6yhr04wvGh Clyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773913065; x=1774517865; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=dNgb6/ySHq+PmuPa2Ob8yekXF7lWjZXA5229XYLgkxs=; b=SGtcqEx8y4oDOMaSA2pWg4jEDVkB7mmzdH1443vCcvcUaye6pV6qISdbAXgDu+OyPG JkcAPWzPkyous9BwDZ8PMJADvHPK0TmWw8aTa96JbULPevbWi7RABQZV1O1gaXZsKKEE sEry5yxSZL2Z92UkOSjnR+0Oqdnl6LsrjcJg/3egfkGoRwEbm/bnsCuJj+93dQiRPISC w/BjaBCd2ZELwhTSq9KoS8NSkZSbxiAs7odnyMJVC0wXDl1PQ5xF/buxMqHEl+4VaXgw PUEOZ4Z1Kj/+lftRCn1iZJ7DonJXnpvNIsARdqGO6JT08XvVIhovHtHK2V6QKW8kNxYX 30EA== X-Gm-Message-State: AOJu0Yzr6cWgjLMHgp8cj/F0I3m7czNbEqI74Zdv1S0P+ZU0mZcZEi0j qUQdPKkt+6h0KIDz6atdcpTv9U1RrCduAGq7k773Q9eNY/ys/1oBkTG2mN2a9uHW/CJh9oSP3V2 ciDkb X-Gm-Gg: ATEYQzzQ/R6MtrqY04smqYLyUjLyQOJWk6h2GprNWmuvyJBl7ec+FIR+OSbR2OsyGE8 3Tq1IPPxO7R3/rnfg1G9DFxchF6honrCs8CKc6bqEz76EI4sirGSWv6S1XY1z9N0TTsNnYflRDV 52ek1guHi0v9hXzLEec7MP0Ph23tL60Uj/tvaME3hWxevhE+0k6uxdyKUqwH2Yw/p5/p8hVUU9f 9jM0K/q0hp6osw4bXwVfdrWAI/drcHKWzqjmCjJZgWQ/o0js5mUdhiZS6KvpRj6SRtKWIAYIzUI ExnvTZIYnFV4YtBJjiJ0kBpnRrL7jNaRPMDnTHMc8mSKq7IDE9d0WBgeNlaq6HmoAkRYwnmONex UIBsys/i1+zowhAybM8UOp2fiTQ9wPmc56Vt9L2r/CSq/ESLAjny9+5m8E2HRtFz9TJjhDJmA0X wjW10jz/C+OySMpXat1u3c+dB6gF9EFzaXVG27tHegec077p3mbEZwV8Q6Z4bwQCo+IcM/FNpkF Gs1YBEclqjfXsfm4mCm5bbv+68= X-Received: by 2002:a17:906:2509:b0:b97:900b:136a with SMTP id a640c23a62f3a-b97f48bdf7dmr363069066b.4.1773913064445; Thu, 19 Mar 2026 02:37:44 -0700 (PDT) Received: from localhost.localdomain (46-117-212-87.ftth.glasoperator.nl. [87.212.117.46]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b97f142cf16sm427306666b.20.2026.03.19.02.37.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 02:37:44 -0700 (PDT) From: Valerie Aurora To: rpdfs-devel@lists.linux.dev Cc: Valerie Aurora Subject: [PATCH 2/3] rpdfs: Initialize block seqlock before using it and fix memleak Date: Thu, 19 Mar 2026 10:37:26 +0100 Message-ID: <20260319093727.15343-3-val@versity.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20260319093727.15343-1-val@versity.com> References: <20260319093727.15343-1-val@versity.com> Precedence: bulk X-Mailing-List: rpdfs-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit alloc_data_page() was using bk->seqlock before it was initialized. Move the lock initializations to before the alloc_data_page() call and free the block struct if it fails. Signed-off-by: Valerie Aurora --- fs/rpdfs/block.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/fs/rpdfs/block.c b/fs/rpdfs/block.c index b614d13f4a2b..825098c0de75 100644 --- a/fs/rpdfs/block.c +++ b/fs/rpdfs/block.c @@ -322,19 +322,20 @@ static struct rpdfs_block *alloc_block(bool with_page, gfp_t gfp) goto out; } + INIT_LIST_HEAD(&bk->lru_head); + atomic64_set(&bk->refcount, 0); + seqlock_init(&bk->seqlock); + init_waitqueue_head(&bk->waitq); + INIT_LIST_HEAD(&bk->dirty_head); + if (with_page) { ret = alloc_data_page(bk, gfp); if (ret < 0) { + kfree(bk); bk = ERR_PTR(ret); goto out; } } - - INIT_LIST_HEAD(&bk->lru_head); - atomic64_set(&bk->refcount, 0); - seqlock_init(&bk->seqlock); - init_waitqueue_head(&bk->waitq); - INIT_LIST_HEAD(&bk->dirty_head); out: return bk; } -- 2.49.0