diff for duplicates of <202603191102.hueYyyPw-lkp@intel.com> diff --git a/a/1.txt b/N1/1.txt index a364c44..3367a2f 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,15 +1,6 @@ -BCC: lkp@intel.com -CC: oe-kbuild-all@lists.linux.dev -CC: linux-kernel@vger.kernel.org -TO: Akhil P Oommen <akhilpo@oss.qualcomm.com> -CC: Rob Clark <robin.clark@oss.qualcomm.com> - tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 8a30aeb0d1b4e4aaf7f7bae72f20f2ae75385ccb commit: 491fadb2b818e1d900229a1f8243de6458381306 drm/msm/adreno: Move adreno_gpu_func to catalogue -date: 4 months ago -:::::: branch date: 6 hours ago -:::::: commit date: 4 months ago config: arm64-randconfig-r073-20260319 (https://download.01.org/0day-ci/archive/20260319/202603191102.hueYyyPw-lkp@intel.com/config) compiler: clang version 23.0.0git (https://github.com/llvm/llvm-project 4abb927bacf37f18f6359a41639a6d1b3bffffb5) smatch: v0.5.0-9004-gb810ac53 @@ -17,7 +8,7 @@ smatch: v0.5.0-9004-gb810ac53 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> -| Reported-by: Dan Carpenter <error27@gmail.com> +| Reported-by: Dan Carpenter <dan.carpenter@linaro.org> | Closes: https://lore.kernel.org/r/202603191102.hueYyyPw-lkp@intel.com/ smatch warnings: @@ -27,7 +18,6 @@ drivers/gpu/drm/msm/adreno/a4xx_gpu.c:642 a4xx_gpu_init() warn: variable derefer vim +/pdev +530 drivers/gpu/drm/msm/adreno/a3xx_gpu.c -70c70f091b1ffd Rob Clark 2014-05-30 517 491fadb2b818e1 Akhil P Oommen 2025-11-18 518 static struct msm_gpu *a3xx_gpu_init(struct drm_device *dev) 7198e6b03155f6 Rob Clark 2013-07-19 519 { 7198e6b03155f6 Rob Clark 2013-07-19 520 struct a3xx_gpu *a3xx_gpu = NULL; @@ -36,81 +26,22 @@ vim +/pdev +530 drivers/gpu/drm/msm/adreno/a3xx_gpu.c 060530f1ea6740 Rob Clark 2014-03-03 523 struct msm_drm_private *priv = dev->dev_private; 060530f1ea6740 Rob Clark 2014-03-03 524 struct platform_device *pdev = priv->gpu_pdev; 491fadb2b818e1 Akhil P Oommen 2025-11-18 @525 struct adreno_platform_config *config = pdev->dev.platform_data; + ^^^^^^ +Patch adds a dereference. + 5785dd7a8ef0de Akhil P Oommen 2020-10-28 526 struct icc_path *ocmem_icc_path; 5785dd7a8ef0de Akhil P Oommen 2020-10-28 527 struct icc_path *icc_path; 7198e6b03155f6 Rob Clark 2013-07-19 528 int ret; 7198e6b03155f6 Rob Clark 2013-07-19 529 7198e6b03155f6 Rob Clark 2013-07-19 @530 if (!pdev) { + ^^^^ +But the old code assumed pdev could be NULL. Probably the NULL checks +are unnecessary. + 6a41da17e87dee Mamta Shukla 2018-10-20 531 DRM_DEV_ERROR(dev->dev, "no a3xx device\n"); 7198e6b03155f6 Rob Clark 2013-07-19 532 ret = -ENXIO; 7198e6b03155f6 Rob Clark 2013-07-19 533 goto fail; 7198e6b03155f6 Rob Clark 2013-07-19 534 } -7198e6b03155f6 Rob Clark 2013-07-19 535 -7198e6b03155f6 Rob Clark 2013-07-19 536 a3xx_gpu = kzalloc(sizeof(*a3xx_gpu), GFP_KERNEL); -7198e6b03155f6 Rob Clark 2013-07-19 537 if (!a3xx_gpu) { -7198e6b03155f6 Rob Clark 2013-07-19 538 ret = -ENOMEM; -7198e6b03155f6 Rob Clark 2013-07-19 539 goto fail; -7198e6b03155f6 Rob Clark 2013-07-19 540 } -7198e6b03155f6 Rob Clark 2013-07-19 541 -55459968176f13 Rob Clark 2013-12-05 542 adreno_gpu = &a3xx_gpu->base; -55459968176f13 Rob Clark 2013-12-05 543 gpu = &adreno_gpu->base; -7198e6b03155f6 Rob Clark 2013-07-19 544 -70c70f091b1ffd Rob Clark 2014-05-30 545 gpu->perfcntrs = perfcntrs; -70c70f091b1ffd Rob Clark 2014-05-30 546 gpu->num_perfcntrs = ARRAY_SIZE(perfcntrs); -70c70f091b1ffd Rob Clark 2014-05-30 547 -3bcefb0497f9fc Rob Clark 2014-09-05 548 adreno_gpu->registers = a3xx_registers; -3bcefb0497f9fc Rob Clark 2014-09-05 549 -491fadb2b818e1 Akhil P Oommen 2025-11-18 550 ret = adreno_gpu_init(dev, pdev, adreno_gpu, config->info->funcs, 1); -7198e6b03155f6 Rob Clark 2013-07-19 551 if (ret) -7198e6b03155f6 Rob Clark 2013-07-19 552 goto fail; -7198e6b03155f6 Rob Clark 2013-07-19 553 -55459968176f13 Rob Clark 2013-12-05 554 /* if needed, allocate gmem: */ -3d6ab124a4d5de Luca Weiss 2024-01-21 555 if (adreno_is_a330(adreno_gpu) || adreno_is_a305b(adreno_gpu)) { -26c0b26dcd005d Brian Masney 2019-08-23 556 ret = adreno_gpu_ocmem_init(&adreno_gpu->base.pdev->dev, -26c0b26dcd005d Brian Masney 2019-08-23 557 adreno_gpu, &a3xx_gpu->ocmem); -26c0b26dcd005d Brian Masney 2019-08-23 558 if (ret) -26c0b26dcd005d Brian Masney 2019-08-23 559 goto fail; -55459968176f13 Rob Clark 2013-12-05 560 } -55459968176f13 Rob Clark 2013-12-05 561 -5785dd7a8ef0de Akhil P Oommen 2020-10-28 562 icc_path = devm_of_icc_get(&pdev->dev, "gfx-mem"); -3eda901995371d Dan Carpenter 2021-10-01 563 if (IS_ERR(icc_path)) { -3eda901995371d Dan Carpenter 2021-10-01 564 ret = PTR_ERR(icc_path); -5785dd7a8ef0de Akhil P Oommen 2020-10-28 565 goto fail; -3eda901995371d Dan Carpenter 2021-10-01 566 } -5785dd7a8ef0de Akhil P Oommen 2020-10-28 567 -5785dd7a8ef0de Akhil P Oommen 2020-10-28 568 ocmem_icc_path = devm_of_icc_get(&pdev->dev, "ocmem"); -3eda901995371d Dan Carpenter 2021-10-01 569 if (IS_ERR(ocmem_icc_path)) { -3eda901995371d Dan Carpenter 2021-10-01 570 ret = PTR_ERR(ocmem_icc_path); -5785dd7a8ef0de Akhil P Oommen 2020-10-28 571 /* allow -ENODATA, ocmem icc is optional */ -5785dd7a8ef0de Akhil P Oommen 2020-10-28 572 if (ret != -ENODATA) -5785dd7a8ef0de Akhil P Oommen 2020-10-28 573 goto fail; -5785dd7a8ef0de Akhil P Oommen 2020-10-28 574 ocmem_icc_path = NULL; -5785dd7a8ef0de Akhil P Oommen 2020-10-28 575 } -5785dd7a8ef0de Akhil P Oommen 2020-10-28 576 -5785dd7a8ef0de Akhil P Oommen 2020-10-28 577 -d163ba0b65f2e4 Brian Masney 2019-11-21 578 /* -d163ba0b65f2e4 Brian Masney 2019-11-21 579 * Set the ICC path to maximum speed for now by multiplying the fastest -d163ba0b65f2e4 Brian Masney 2019-11-21 580 * frequency by the bus width (8). We'll want to scale this later on to -d163ba0b65f2e4 Brian Masney 2019-11-21 581 * improve battery life. -d163ba0b65f2e4 Brian Masney 2019-11-21 582 */ -5785dd7a8ef0de Akhil P Oommen 2020-10-28 583 icc_set_bw(icc_path, 0, Bps_to_icc(gpu->fast_rate) * 8); -5785dd7a8ef0de Akhil P Oommen 2020-10-28 584 icc_set_bw(ocmem_icc_path, 0, Bps_to_icc(gpu->fast_rate) * 8); -d163ba0b65f2e4 Brian Masney 2019-11-21 585 -871d812aa43e63 Rob Clark 2013-11-16 586 return gpu; -7198e6b03155f6 Rob Clark 2013-07-19 587 -7198e6b03155f6 Rob Clark 2013-07-19 588 fail: -7198e6b03155f6 Rob Clark 2013-07-19 589 if (a3xx_gpu) -7198e6b03155f6 Rob Clark 2013-07-19 590 a3xx_destroy(&a3xx_gpu->base.base); -7198e6b03155f6 Rob Clark 2013-07-19 591 -7198e6b03155f6 Rob Clark 2013-07-19 592 return ERR_PTR(ret); -7198e6b03155f6 Rob Clark 2013-07-19 593 } -491fadb2b818e1 Akhil P Oommen 2025-11-18 594 - -:::::: The code at line 530 was first introduced by commit -:::::: 7198e6b03155f6dadecadba004eb83b81a6ffe4c drm/msm: add a3xx gpu support - -:::::: TO: Rob Clark <robdclark@gmail.com> -:::::: CC: Rob Clark <robdclark@gmail.com> -- 0-DAY CI Kernel Test Service diff --git a/a/content_digest b/N1/content_digest index d7501a2..8d2ff40 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,23 +1,17 @@ - "From\0kernel test robot <lkp@intel.com>\0" + "From\0Dan Carpenter <dan.carpenter@linaro.org>\0" "Subject\0drivers/gpu/drm/msm/adreno/a3xx_gpu.c:530 a3xx_gpu_init() warn: variable dereferenced before check 'pdev' (see line 525)\0" - "Date\0Thu, 19 Mar 2026 11:38:57 +0800\0" - "To\0oe-kbuild@lists.linux.dev\0" + "Date\0Thu, 19 Mar 2026 12:19:09 +0300\0" + "To\0oe-kbuild@lists.linux.dev" + " Akhil P Oommen <akhilpo@oss.qualcomm.com>\0" "Cc\0lkp@intel.com" - " Dan Carpenter <error27@gmail.com>\0" + oe-kbuild-all@lists.linux.dev + linux-kernel@vger.kernel.org + " Rob Clark <robin.clark@oss.qualcomm.com>\0" "\00:1\0" "b\0" - "BCC: lkp@intel.com\n" - "CC: oe-kbuild-all@lists.linux.dev\n" - "CC: linux-kernel@vger.kernel.org\n" - "TO: Akhil P Oommen <akhilpo@oss.qualcomm.com>\n" - "CC: Rob Clark <robin.clark@oss.qualcomm.com>\n" - "\n" "tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master\n" "head: 8a30aeb0d1b4e4aaf7f7bae72f20f2ae75385ccb\n" "commit: 491fadb2b818e1d900229a1f8243de6458381306 drm/msm/adreno: Move adreno_gpu_func to catalogue\n" - "date: 4 months ago\n" - ":::::: branch date: 6 hours ago\n" - ":::::: commit date: 4 months ago\n" "config: arm64-randconfig-r073-20260319 (https://download.01.org/0day-ci/archive/20260319/202603191102.hueYyyPw-lkp@intel.com/config)\n" "compiler: clang version 23.0.0git (https://github.com/llvm/llvm-project 4abb927bacf37f18f6359a41639a6d1b3bffffb5)\n" "smatch: v0.5.0-9004-gb810ac53\n" @@ -25,7 +19,7 @@ "If you fix the issue in a separate patch/commit (i.e. not just a new version of\n" "the same patch/commit), kindly add following tags\n" "| Reported-by: kernel test robot <lkp@intel.com>\n" - "| Reported-by: Dan Carpenter <error27@gmail.com>\n" + "| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>\n" "| Closes: https://lore.kernel.org/r/202603191102.hueYyyPw-lkp@intel.com/\n" "\n" "smatch warnings:\n" @@ -35,7 +29,6 @@ "\n" "vim +/pdev +530 drivers/gpu/drm/msm/adreno/a3xx_gpu.c\n" "\n" - "70c70f091b1ffd Rob Clark 2014-05-30 517 \n" "491fadb2b818e1 Akhil P Oommen 2025-11-18 518 static struct msm_gpu *a3xx_gpu_init(struct drm_device *dev)\n" "7198e6b03155f6 Rob Clark 2013-07-19 519 {\n" "7198e6b03155f6 Rob Clark 2013-07-19 520 \tstruct a3xx_gpu *a3xx_gpu = NULL;\n" @@ -44,84 +37,25 @@ "060530f1ea6740 Rob Clark 2014-03-03 523 \tstruct msm_drm_private *priv = dev->dev_private;\n" "060530f1ea6740 Rob Clark 2014-03-03 524 \tstruct platform_device *pdev = priv->gpu_pdev;\n" "491fadb2b818e1 Akhil P Oommen 2025-11-18 @525 \tstruct adreno_platform_config *config = pdev->dev.platform_data;\n" + " ^^^^^^\n" + "Patch adds a dereference.\n" + "\n" "5785dd7a8ef0de Akhil P Oommen 2020-10-28 526 \tstruct icc_path *ocmem_icc_path;\n" "5785dd7a8ef0de Akhil P Oommen 2020-10-28 527 \tstruct icc_path *icc_path;\n" "7198e6b03155f6 Rob Clark 2013-07-19 528 \tint ret;\n" "7198e6b03155f6 Rob Clark 2013-07-19 529 \n" "7198e6b03155f6 Rob Clark 2013-07-19 @530 \tif (!pdev) {\n" + " ^^^^\n" + "But the old code assumed pdev could be NULL. Probably the NULL checks\n" + "are unnecessary.\n" + "\n" "6a41da17e87dee Mamta Shukla 2018-10-20 531 \t\tDRM_DEV_ERROR(dev->dev, \"no a3xx device\\n\");\n" "7198e6b03155f6 Rob Clark 2013-07-19 532 \t\tret = -ENXIO;\n" "7198e6b03155f6 Rob Clark 2013-07-19 533 \t\tgoto fail;\n" "7198e6b03155f6 Rob Clark 2013-07-19 534 \t}\n" - "7198e6b03155f6 Rob Clark 2013-07-19 535 \n" - "7198e6b03155f6 Rob Clark 2013-07-19 536 \ta3xx_gpu = kzalloc(sizeof(*a3xx_gpu), GFP_KERNEL);\n" - "7198e6b03155f6 Rob Clark 2013-07-19 537 \tif (!a3xx_gpu) {\n" - "7198e6b03155f6 Rob Clark 2013-07-19 538 \t\tret = -ENOMEM;\n" - "7198e6b03155f6 Rob Clark 2013-07-19 539 \t\tgoto fail;\n" - "7198e6b03155f6 Rob Clark 2013-07-19 540 \t}\n" - "7198e6b03155f6 Rob Clark 2013-07-19 541 \n" - "55459968176f13 Rob Clark 2013-12-05 542 \tadreno_gpu = &a3xx_gpu->base;\n" - "55459968176f13 Rob Clark 2013-12-05 543 \tgpu = &adreno_gpu->base;\n" - "7198e6b03155f6 Rob Clark 2013-07-19 544 \n" - "70c70f091b1ffd Rob Clark 2014-05-30 545 \tgpu->perfcntrs = perfcntrs;\n" - "70c70f091b1ffd Rob Clark 2014-05-30 546 \tgpu->num_perfcntrs = ARRAY_SIZE(perfcntrs);\n" - "70c70f091b1ffd Rob Clark 2014-05-30 547 \n" - "3bcefb0497f9fc Rob Clark 2014-09-05 548 \tadreno_gpu->registers = a3xx_registers;\n" - "3bcefb0497f9fc Rob Clark 2014-09-05 549 \n" - "491fadb2b818e1 Akhil P Oommen 2025-11-18 550 \tret = adreno_gpu_init(dev, pdev, adreno_gpu, config->info->funcs, 1);\n" - "7198e6b03155f6 Rob Clark 2013-07-19 551 \tif (ret)\n" - "7198e6b03155f6 Rob Clark 2013-07-19 552 \t\tgoto fail;\n" - "7198e6b03155f6 Rob Clark 2013-07-19 553 \n" - "55459968176f13 Rob Clark 2013-12-05 554 \t/* if needed, allocate gmem: */\n" - "3d6ab124a4d5de Luca Weiss 2024-01-21 555 \tif (adreno_is_a330(adreno_gpu) || adreno_is_a305b(adreno_gpu)) {\n" - "26c0b26dcd005d Brian Masney 2019-08-23 556 \t\tret = adreno_gpu_ocmem_init(&adreno_gpu->base.pdev->dev,\n" - "26c0b26dcd005d Brian Masney 2019-08-23 557 \t\t\t\t\t adreno_gpu, &a3xx_gpu->ocmem);\n" - "26c0b26dcd005d Brian Masney 2019-08-23 558 \t\tif (ret)\n" - "26c0b26dcd005d Brian Masney 2019-08-23 559 \t\t\tgoto fail;\n" - "55459968176f13 Rob Clark 2013-12-05 560 \t}\n" - "55459968176f13 Rob Clark 2013-12-05 561 \n" - "5785dd7a8ef0de Akhil P Oommen 2020-10-28 562 \ticc_path = devm_of_icc_get(&pdev->dev, \"gfx-mem\");\n" - "3eda901995371d Dan Carpenter 2021-10-01 563 \tif (IS_ERR(icc_path)) {\n" - "3eda901995371d Dan Carpenter 2021-10-01 564 \t\tret = PTR_ERR(icc_path);\n" - "5785dd7a8ef0de Akhil P Oommen 2020-10-28 565 \t\tgoto fail;\n" - "3eda901995371d Dan Carpenter 2021-10-01 566 \t}\n" - "5785dd7a8ef0de Akhil P Oommen 2020-10-28 567 \n" - "5785dd7a8ef0de Akhil P Oommen 2020-10-28 568 \tocmem_icc_path = devm_of_icc_get(&pdev->dev, \"ocmem\");\n" - "3eda901995371d Dan Carpenter 2021-10-01 569 \tif (IS_ERR(ocmem_icc_path)) {\n" - "3eda901995371d Dan Carpenter 2021-10-01 570 \t\tret = PTR_ERR(ocmem_icc_path);\n" - "5785dd7a8ef0de Akhil P Oommen 2020-10-28 571 \t\t/* allow -ENODATA, ocmem icc is optional */\n" - "5785dd7a8ef0de Akhil P Oommen 2020-10-28 572 \t\tif (ret != -ENODATA)\n" - "5785dd7a8ef0de Akhil P Oommen 2020-10-28 573 \t\t\tgoto fail;\n" - "5785dd7a8ef0de Akhil P Oommen 2020-10-28 574 \t\tocmem_icc_path = NULL;\n" - "5785dd7a8ef0de Akhil P Oommen 2020-10-28 575 \t}\n" - "5785dd7a8ef0de Akhil P Oommen 2020-10-28 576 \n" - "5785dd7a8ef0de Akhil P Oommen 2020-10-28 577 \n" - "d163ba0b65f2e4 Brian Masney 2019-11-21 578 \t/*\n" - "d163ba0b65f2e4 Brian Masney 2019-11-21 579 \t * Set the ICC path to maximum speed for now by multiplying the fastest\n" - "d163ba0b65f2e4 Brian Masney 2019-11-21 580 \t * frequency by the bus width (8). We'll want to scale this later on to\n" - "d163ba0b65f2e4 Brian Masney 2019-11-21 581 \t * improve battery life.\n" - "d163ba0b65f2e4 Brian Masney 2019-11-21 582 \t */\n" - "5785dd7a8ef0de Akhil P Oommen 2020-10-28 583 \ticc_set_bw(icc_path, 0, Bps_to_icc(gpu->fast_rate) * 8);\n" - "5785dd7a8ef0de Akhil P Oommen 2020-10-28 584 \ticc_set_bw(ocmem_icc_path, 0, Bps_to_icc(gpu->fast_rate) * 8);\n" - "d163ba0b65f2e4 Brian Masney 2019-11-21 585 \n" - "871d812aa43e63 Rob Clark 2013-11-16 586 \treturn gpu;\n" - "7198e6b03155f6 Rob Clark 2013-07-19 587 \n" - "7198e6b03155f6 Rob Clark 2013-07-19 588 fail:\n" - "7198e6b03155f6 Rob Clark 2013-07-19 589 \tif (a3xx_gpu)\n" - "7198e6b03155f6 Rob Clark 2013-07-19 590 \t\ta3xx_destroy(&a3xx_gpu->base.base);\n" - "7198e6b03155f6 Rob Clark 2013-07-19 591 \n" - "7198e6b03155f6 Rob Clark 2013-07-19 592 \treturn ERR_PTR(ret);\n" - "7198e6b03155f6 Rob Clark 2013-07-19 593 }\n" - "491fadb2b818e1 Akhil P Oommen 2025-11-18 594 \n" - "\n" - ":::::: The code at line 530 was first introduced by commit\n" - ":::::: 7198e6b03155f6dadecadba004eb83b81a6ffe4c drm/msm: add a3xx gpu support\n" - "\n" - ":::::: TO: Rob Clark <robdclark@gmail.com>\n" - ":::::: CC: Rob Clark <robdclark@gmail.com>\n" "\n" "-- \n" "0-DAY CI Kernel Test Service\n" https://github.com/intel/lkp-tests/wiki -635a6171f7a4a899dc9df046769d229789a6b2204d02199149cce32d910b1c43 +3823a95b2b605816684fea5b71a2ccee118777e04b285e684e75a5ad0a301777
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.