All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jonathan.cameron@huawei.com>
To: Dave Jiang <dave.jiang@intel.com>
Cc: <linux-cxl@vger.kernel.org>, <dan.j.williams@intel.com>,
	<vishal.l.verma@intel.com>, <ira.weiny@intel.com>,
	<dave@stgolabs.net>, <alison.schofield@intel.com>
Subject: Re: [PATCH v2] cxl: Add endpoint decoder flags clear when PCI reset happens
Date: Thu, 19 Mar 2026 14:46:13 +0000	[thread overview]
Message-ID: <20260319144613.00003ea6@huawei.com> (raw)
In-Reply-To: <20260317234926.3545119-1-dave.jiang@intel.com>

On Tue, 17 Mar 2026 16:49:26 -0700
Dave Jiang <dave.jiang@intel.com> wrote:

> When a PCI reset happens, the lock and enable flags of the CXL device
> should be cleared to avoid stale state flags after reset. Add flag
> clearing during cxl_reset_done() to clear the relevant endpoint
> decoder flags for all decoders of the endpoint device.
> 
> Reported-by: Dan Williams <dan.j.williams@intel.com>
> Reviewed-by: Alison Schofield <alison.schofield@intel.com>
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> ---
> v2:
> - Rename CLEAR_MASK to RESET_MASK (Alison)
> - Make the helper function take a mask argument to specify which flags
>   to clear (Alison)
Unless we know of another use for this helper, I'd have gone with
Alison's other alternative of just giving it a more specific name
and not passing in a flags parameter.  Feels like a bit of premature
generalization!


  parent reply	other threads:[~2026-03-19 14:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-17 23:49 [PATCH v2] cxl: Add endpoint decoder flags clear when PCI reset happens Dave Jiang
2026-03-18 14:12 ` Cheatham, Benjamin
2026-03-18 15:22   ` Dave Jiang
2026-03-18 15:26     ` Dave Jiang
2026-03-19 14:46 ` Jonathan Cameron [this message]
2026-03-19 15:03   ` Dave Jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260319144613.00003ea6@huawei.com \
    --to=jonathan.cameron@huawei.com \
    --cc=alison.schofield@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=dave@stgolabs.net \
    --cc=ira.weiny@intel.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.