All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ibrahim Zein <zeroxjacks@gmail.com>
To: paul.chaignon@gmail.com
Cc: bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
	martin.lau@linux.dev, andrii@kernel.org, eddyz87@gmail.com
Subject: Re: [PATCH bpf-next v3] bpf: fix out-of-bounds write in bpf_bprintf_prepare with %pI4/%pI6
Date: Thu, 19 Mar 2026 19:08:29 +0000	[thread overview]
Message-ID: <20260319190829.14244-1-zeroxjacks@gmail.com> (raw)
In-Reply-To: <20260319125800.0000-1-paul.chaignon@gmail.com>

Hi Paul,

Apologies for dropping the list from CC, I will keep everyone in copy.

Regarding the (size_t) cast: agreed, I will remove it in v4.

Regarding the test: you are right. BPF_SNPRINTF is limited to 12
arguments, which is not enough to fill 512 bytes of bin_args with
scalar args alone to trigger the overflow path.

Would it be acceptable to keep the test as a regression test for
correct %pI4/%pI6 formatting, or should I remove it entirely?

Best regards,
Ibrahim Zein

       reply	other threads:[~2026-03-19 19:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260319125800.0000-1-paul.chaignon@gmail.com>
2026-03-19 19:08 ` Ibrahim Zein [this message]
2026-03-19 12:49 [PATCH bpf-next v3] bpf: fix out-of-bounds write in bpf_bprintf_prepare with %pI4/%pI6 Ibrahim Zein
2026-03-19 14:47 ` Paul Chaignon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260319190829.14244-1-zeroxjacks@gmail.com \
    --to=zeroxjacks@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=martin.lau@linux.dev \
    --cc=paul.chaignon@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.