From: Greg KH <gregkh@linuxfoundation.org>
To: Sudarshan Srinivasan <ss22.kern.dev@gmail.com>
Cc: mchehab@kernel.org, linux-media@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: media: av7110: coding style fixes: too many tabs
Date: Thu, 19 Mar 2026 07:37:33 +0100 [thread overview]
Message-ID: <2026031922-unafraid-fable-f24b@gregkh> (raw)
In-Reply-To: <20260318191149.109616-1-ss22.kern.dev@gmail.com>
On Thu, Mar 19, 2026 at 12:41:47AM +0530, Sudarshan Srinivasan wrote:
> This patch fixes below warning reported by checkpatch.pl
> WARNING: Too many leading tabs - consider code refactoring
>
> Signed-off-by: Sudarshan Srinivasan <ss22.kern.dev@gmail.com>
> ---
> drivers/staging/media/av7110/av7110.c | 32 ++++++++++++++++++---------
> 1 file changed, 22 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/staging/media/av7110/av7110.c b/drivers/staging/media/av7110/av7110.c
> index 607992100baf..970343c4ec51 100644
> --- a/drivers/staging/media/av7110/av7110.c
> +++ b/drivers/staging/media/av7110/av7110.c
> @@ -932,6 +932,27 @@ static int dvb_feed_stop_pid(struct dvb_demux_feed *dvbdmxfeed)
> return ret;
> }
>
> +static int handle_ts_memory_fe(struct dvb_demux_feed *feed,
> + struct dvb_demux *demux,
> + struct av7110 *av7110)
> +{
> + int ret = 0;
> +
> + if (feed->pes_type >= 2)
> + return 0;
> +
> + if ((demux->pids[0] & 0x8000) || (demux->pids[1] & 0x8000))
> + return 0;
> +
> + dvb_ringbuffer_flush_spinlock_wakeup(&av7110->avout);
> + dvb_ringbuffer_flush_spinlock_wakeup(&av7110->aout);
> +
> + ret = av7110_av_start_play(av7110, RP_AV);
> + demux->playing = (ret) ? true : false;
> +
> + return ret;
> +}
I think you still have too many tabs here :(
next prev parent reply other threads:[~2026-03-19 6:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-18 19:11 [PATCH] staging: media: av7110: coding style fixes: too many tabs Sudarshan Srinivasan
2026-03-19 6:37 ` Greg KH [this message]
2026-03-19 9:02 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2026-03-16 15:23 Sudarshan Srinivasan
2026-03-16 15:34 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026031922-unafraid-fable-f24b@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=ss22.kern.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.