All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Zile Xiong <xiongzile99@gmail.com>
Cc: andy@kernel.org, hansg@kernel.org, mchehab@kernel.org,
	sakari.ailus@linux.intel.com, linux-kernel@vger.kernel.org,
	linux-media@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: media: atomisp: hmm: remove unnecessary casts
Date: Thu, 19 Mar 2026 10:42:55 +0100	[thread overview]
Message-ID: <2026031933-juggle-decimeter-3547@gregkh> (raw)
In-Reply-To: <20260319093625.3225-1-xiongzile99@gmail.com>

On Thu, Mar 19, 2026 at 05:36:25PM +0800, Zile Xiong wrote:
> Drop unnecessary casts when accessing vma->vm_private_data.
> 
> No functional change.
> 
> Signed-off-by: Zile Xiong <xiongzile99@gmail.com>
> ---
>  drivers/staging/media/atomisp/pci/hmm/hmm_bo.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/hmm/hmm_bo.c b/drivers/staging/media/atomisp/pci/hmm/hmm_bo.c
> index 856561e951a5..68116edda591 100644
> --- a/drivers/staging/media/atomisp/pci/hmm/hmm_bo.c
> +++ b/drivers/staging/media/atomisp/pci/hmm/hmm_bo.c
> @@ -975,9 +975,7 @@ void hmm_bo_unref(struct hmm_buffer_object *bo)
>  
>  static void hmm_bo_vm_open(struct vm_area_struct *vma)
>  {
> -	struct hmm_buffer_object *bo =
> -	    (struct hmm_buffer_object *)vma->vm_private_data;
> -
> +	struct hmm_buffer_object *bo = vma->vm_private_data;
>  	check_bo_null_return_void(bo);
>  
>  	hmm_bo_ref(bo);

Why did you delete the extra blank line that checkpatch is just going to
ask you to add back again in a future change?  :)

thanks,

greg k-h

  reply	other threads:[~2026-03-19  9:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-19  9:36 [PATCH] staging: media: atomisp: hmm: remove unnecessary casts Zile Xiong
2026-03-19  9:42 ` Greg KH [this message]
2026-03-19 10:35   ` [PATCH v2] " Zile Xiong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026031933-juggle-decimeter-3547@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=andy@kernel.org \
    --cc=hansg@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=xiongzile99@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.