All of lore.kernel.org
 help / color / mirror / Atom feed
From: <gregkh@linuxfoundation.org>
To: Liam.Howlett@Oracle.com,akpm@linux-foundation.org,cl@linux.com,david@kernel.org,gourry@gourry.net,gregkh@linuxfoundation.org,linux-mm@kvack.org,liying3@sungrowpower.com,willy@infradead.org
Cc: <stable-commits@vger.kernel.org>
Subject: Patch "mm/mempolicy: fix wrong mmap_read_unlock() in migrate_to_node()" has been added to the 6.6-stable tree
Date: Thu, 19 Mar 2026 15:09:46 +0100	[thread overview]
Message-ID: <2026031946-transfer-ranger-7165@gregkh> (raw)
In-Reply-To: <20260303101245.22290-1-david@kernel.org>


This is a note to let you know that I've just added the patch titled

    mm/mempolicy: fix wrong mmap_read_unlock() in migrate_to_node()

to the 6.6-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     mm-mempolicy-fix-wrong-mmap_read_unlock-in-migrate_to_node.patch
and it can be found in the queue-6.6 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


From david@kernel.org  Thu Mar 19 14:49:55 2026
From: "David Hildenbrand (Arm)" <david@kernel.org>
Date: Tue,  3 Mar 2026 11:12:45 +0100
Subject: mm/mempolicy: fix wrong mmap_read_unlock() in migrate_to_node()
To: stable@vger.kernel.org
Cc: linux-mm <linux-mm@kvack.org>, "David Hildenbrand (Arm)" <david@kernel.org>, Li Ying <liying3@sungrowpower.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Andrew Morton <akpm@linux-foundation.org>, Matthew Wilcox <willy@infradead.org>, Christoph Lameter <cl@linux.com>, "Liam R . Howlett" <Liam.Howlett@Oracle.com>
Message-ID: <20260303101245.22290-1-david@kernel.org>

From: "David Hildenbrand (Arm)" <david@kernel.org>

The backport of commit 091c1dd2d4df ("mm/mempolicy: fix migrate_to_node()
assuming there is at least one VMA in a MM") contains an error:
migrate_to_node() does not lock the mmap_lock itself, that is handled by
the caller instead.

So let's drop the wrong mmap_read_unlock(). Fortunately, this path is
very hard to hit in practice.

Fixes: a13b2b9b0b0b ("mm/mempolicy: fix migrate_to_node() assuming there is at least one VMA in a MM")
Reported-by: Li Ying <liying3@sungrowpower.com>
Closes: https://lore.kernel.org/r/aaZgUNxAyKC2IwuG@casper.infradead.org
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Christoph Lameter <cl@linux.com>
Cc: <stable@vger.kernel.org>
Reviewed-by: Gregory Price <gourry@gourry.net>
Reviewed-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
Signed-off-by: David Hildenbrand (Arm) <david@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 mm/mempolicy.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

--- a/mm/mempolicy.c
+++ b/mm/mempolicy.c
@@ -1071,10 +1071,8 @@ static long migrate_to_node(struct mm_st
 
 	VM_BUG_ON(!(flags & (MPOL_MF_MOVE | MPOL_MF_MOVE_ALL)));
 	vma = find_vma(mm, 0);
-	if (unlikely(!vma)) {
-		mmap_read_unlock(mm);
+	if (unlikely(!vma))
 		return 0;
-	}
 
 	/*
 	 * This does not migrate the range, but isolates all pages that


Patches currently in stable-queue which might be from david@kernel.org are

queue-6.6/mm-mempolicy-fix-wrong-mmap_read_unlock-in-migrate_to_node.patch
queue-6.6/mm-tracing-rss_stat-ensure-curr-is-false-from-kthread-context.patch


      parent reply	other threads:[~2026-03-19 14:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-03 10:12 [PATCH 6.6.y] mm/mempolicy: fix wrong mmap_read_unlock() in migrate_to_node() David Hildenbrand (Arm)
2026-03-03 15:24 ` Liam R. Howlett
2026-03-04 17:40 ` Gregory Price
2026-03-19 14:09 ` gregkh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026031946-transfer-ranger-7165@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=Liam.Howlett@Oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=david@kernel.org \
    --cc=gourry@gourry.net \
    --cc=linux-mm@kvack.org \
    --cc=liying3@sungrowpower.com \
    --cc=stable-commits@vger.kernel.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.