All of lore.kernel.org
 help / color / mirror / Atom feed
From: Artem Shimko <a.shimko.dev@gmail.com>
To: wim@linux-watchdog.org, linux@roeck-us.net,
	p.zabel@pengutronix.de, Sergey.Semin@baikalelectronics.ru,
	mika.westerberg@linux.intel.com, andi.shyti@kernel.org
Cc: Artem Shimko <a.shimko.dev@gmail.com>,
	linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/5] watchdog: dw_wdt: reset clean up and pm
Date: Fri, 20 Mar 2026 16:56:17 +0300	[thread overview]
Message-ID: <20260320135624.223863-1-a.shimko.dev@gmail.com> (raw)

Hello maintainers and reviewers,

Patch 1 moves reset_control_deassert() before any register access to
ensure the watchdog controller is properly taken out of reset before
configuration, fixing a potential hardware access issue.

Patch 2 adds proper error handling for reset_control_deassert() to
prevent probe from continuing when reset deassertion fails, improving
diagnostics and reliability.

Patch 3 replaces manual reset control management with the
devm_reset_control_get_optional_shared_deasserted() helper, eliminating
explicit reset_control_assert() calls in error paths and remove.

Patch 4 adds reset line management during system suspend and resume,
asserting the reset before clocks are disabled and deasserting after
clocks are re-enabled to maintain consistent hardware state.

Patch 5 is a final cleanup of the resume function error handling.

Thank you!
--
Best regards,
Artem Shimko

Artem Shimko (5):
  watchdog: dw_wdt: move reset control deassertion before register
    access
  watchdog: dw_wdt: add error handling for reset control deassertion
  watchdog: dw_wdt: Use
    devm_reset_control_get_optional_shared_deasserted
  watchdog: dw_wdt: manage reset line during system suspend/resume
  watchdog: dw_wdt: clean up error paths in resume function

 drivers/watchdog/dw_wdt.c | 37 +++++++++++++++++++++----------------
 1 file changed, 21 insertions(+), 16 deletions(-)

-- 
2.43.0


             reply	other threads:[~2026-03-20 13:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-20 13:56 Artem Shimko [this message]
2026-03-20 13:56 ` [PATCH 1/5] watchdog: dw_wdt: move reset control deassertion before register access Artem Shimko
2026-03-20 13:56 ` [PATCH 2/5] watchdog: dw_wdt: add error handling for reset control deassertion Artem Shimko
2026-03-20 13:56 ` [PATCH 3/5] watchdog: dw_wdt: Use devm_reset_control_get_optional_shared_deasserted Artem Shimko
2026-03-20 13:56 ` [PATCH 4/5] watchdog: dw_wdt: manage reset line during system suspend/resume Artem Shimko
2026-03-20 13:56 ` [PATCH 5/5] watchdog: dw_wdt: clean up error paths in resume function Artem Shimko
2026-05-03 16:23 ` [PATCH 0/5] watchdog: dw_wdt: reset clean up and pm Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260320135624.223863-1-a.shimko.dev@gmail.com \
    --to=a.shimko.dev@gmail.com \
    --cc=Sergey.Semin@baikalelectronics.ru \
    --cc=andi.shyti@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mika.westerberg@linux.intel.com \
    --cc=p.zabel@pengutronix.de \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.