From: kernel test robot <lkp@intel.com>
To: "Peter Zijlstra (Intel)" <peterz@infradead.org>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [peterz-queue:sched/flat 21/21] kernel/sched/fair.c:4067:1: warning: control reaches end of non-void function
Date: Fri, 20 Mar 2026 16:49:56 +0800 [thread overview]
Message-ID: <202603201652.XGsoWx79-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git sched/flat
head: 4974c93ce402d69988eb7b2e9e490c22cc22bb7b
commit: 4974c93ce402d69988eb7b2e9e490c22cc22bb7b [21/21] sched/eevdf: Move to a single runqueue
config: i386-allnoconfig (https://download.01.org/0day-ci/archive/20260320/202603201652.XGsoWx79-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260320/202603201652.XGsoWx79-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603201652.XGsoWx79-lkp@intel.com/
All error/warnings (new ones prefixed by >>):
In file included from include/linux/nodemask.h:92,
from include/linux/numa.h:6,
from include/linux/cpumask.h:15,
from include/linux/energy_model.h:4,
from kernel/sched/fair.c:23:
kernel/sched/fair.c: In function '__calc_prop_weight':
kernel/sched/fair.c:4066:28: error: 'MIN_SHARES' undeclared (first use in this function)
4066 | return max(weight, MIN_SHARES);
| ^~~~~~~~~~
include/linux/minmax.h:92:35: note: in definition of macro '__careful_cmp_once'
92 | auto ux = (x); auto uy = (y); \
| ^
include/linux/minmax.h:112:25: note: in expansion of macro '__careful_cmp'
112 | #define max(x, y) __careful_cmp(max, x, y)
| ^~~~~~~~~~~~~
kernel/sched/fair.c:4066:16: note: in expansion of macro 'max'
4066 | return max(weight, MIN_SHARES);
| ^~~
kernel/sched/fair.c:4066:28: note: each undeclared identifier is reported only once for each function it appears in
4066 | return max(weight, MIN_SHARES);
| ^~~~~~~~~~
include/linux/minmax.h:92:35: note: in definition of macro '__careful_cmp_once'
92 | auto ux = (x); auto uy = (y); \
| ^
include/linux/minmax.h:112:25: note: in expansion of macro '__careful_cmp'
112 | #define max(x, y) __careful_cmp(max, x, y)
| ^~~~~~~~~~~~~
kernel/sched/fair.c:4066:16: note: in expansion of macro 'max'
4066 | return max(weight, MIN_SHARES);
| ^~~
In file included from <command-line>:
>> include/linux/compiler.h:168:17: error: '__UNIQUE_ID_y__460' undeclared (first use in this function); did you mean '__UNIQUE_ID_x__459'?
168 | __PASTE(__UNIQUE_ID_, \
| ^~~~~~~~~~~~
include/linux/compiler_types.h:686:23: note: in definition of macro '__compiletime_assert'
686 | if (!(condition)) \
| ^~~~~~~~~
include/linux/compiler_types.h:706:9: note: in expansion of macro '_compiletime_assert'
706 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert'
39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
| ^~~~~~~~~~~~~~~~~~
include/linux/minmax.h:93:9: note: in expansion of macro 'BUILD_BUG_ON_MSG'
93 | BUILD_BUG_ON_MSG(!__types_ok(ux, uy), \
| ^~~~~~~~~~~~~~~~
include/linux/minmax.h:49:25: note: in expansion of macro 'is_signed_type'
49 | #define __sign_use(ux) (is_signed_type(typeof(ux)) ? \
| ^~~~~~~~~~~~~~
include/linux/minmax.h:75:27: note: in expansion of macro '__sign_use'
75 | (__sign_use(ux) & __sign_use(uy))
| ^~~~~~~~~~
include/linux/minmax.h:93:27: note: in expansion of macro '__types_ok'
93 | BUILD_BUG_ON_MSG(!__types_ok(ux, uy), \
| ^~~~~~~~~~
include/linux/minmax.h:98:9: note: in expansion of macro '__careful_cmp_once'
98 | __careful_cmp_once(op, x, y, __UNIQUE_ID(x_), __UNIQUE_ID(y_))
| ^~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:16:23: note: in expansion of macro '___PASTE'
16 | #define __PASTE(a, b) ___PASTE(a, b)
| ^~~~~~~~
include/linux/compiler.h:168:9: note: in expansion of macro '__PASTE'
168 | __PASTE(__UNIQUE_ID_, \
| ^~~~~~~
include/linux/minmax.h:98:55: note: in expansion of macro '__UNIQUE_ID'
98 | __careful_cmp_once(op, x, y, __UNIQUE_ID(x_), __UNIQUE_ID(y_))
| ^~~~~~~~~~~
include/linux/minmax.h:112:25: note: in expansion of macro '__careful_cmp'
112 | #define max(x, y) __careful_cmp(max, x, y)
| ^~~~~~~~~~~~~
kernel/sched/fair.c:4066:16: note: in expansion of macro 'max'
4066 | return max(weight, MIN_SHARES);
| ^~~
include/linux/minmax.h:71:17: error: first argument to '__builtin_choose_expr' not a constant
71 | (typeof(__builtin_choose_expr(sizeof(ux) > 4, 1LL, 1L)))(ux) >= 0)
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:686:23: note: in definition of macro '__compiletime_assert'
686 | if (!(condition)) \
| ^~~~~~~~~
include/linux/compiler_types.h:706:9: note: in expansion of macro '_compiletime_assert'
706 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert'
39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
| ^~~~~~~~~~~~~~~~~~
include/linux/minmax.h:93:9: note: in expansion of macro 'BUILD_BUG_ON_MSG'
93 | BUILD_BUG_ON_MSG(!__types_ok(ux, uy), \
| ^~~~~~~~~~~~~~~~
include/linux/minmax.h:70:25: note: in expansion of macro 'statically_true'
70 | #define __is_nonneg(ux) statically_true( \
| ^~~~~~~~~~~~~~~
include/linux/minmax.h:50:14: note: in expansion of macro '__is_nonneg'
50 | (2 + __is_nonneg(ux)) : (1 + 2 * (sizeof(ux) < 4)))
| ^~~~~~~~~~~
include/linux/minmax.h:75:27: note: in expansion of macro '__sign_use'
75 | (__sign_use(ux) & __sign_use(uy))
| ^~~~~~~~~~
include/linux/minmax.h:93:27: note: in expansion of macro '__types_ok'
93 | BUILD_BUG_ON_MSG(!__types_ok(ux, uy), \
| ^~~~~~~~~~
include/linux/minmax.h:98:9: note: in expansion of macro '__careful_cmp_once'
98 | __careful_cmp_once(op, x, y, __UNIQUE_ID(x_), __UNIQUE_ID(y_))
| ^~~~~~~~~~~~~~~~~~
include/linux/minmax.h:112:25: note: in expansion of macro '__careful_cmp'
112 | #define max(x, y) __careful_cmp(max, x, y)
| ^~~~~~~~~~~~~
kernel/sched/fair.c:4066:16: note: in expansion of macro 'max'
4066 | return max(weight, MIN_SHARES);
| ^~~
include/linux/minmax.h:71:17: error: first argument to '__builtin_choose_expr' not a constant
71 | (typeof(__builtin_choose_expr(sizeof(ux) > 4, 1LL, 1L)))(ux) >= 0)
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:686:23: note: in definition of macro '__compiletime_assert'
686 | if (!(condition)) \
| ^~~~~~~~~
include/linux/compiler_types.h:706:9: note: in expansion of macro '_compiletime_assert'
706 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert'
39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
| ^~~~~~~~~~~~~~~~~~
include/linux/minmax.h:93:9: note: in expansion of macro 'BUILD_BUG_ON_MSG'
93 | BUILD_BUG_ON_MSG(!__types_ok(ux, uy), \
| ^~~~~~~~~~~~~~~~
include/linux/minmax.h:70:25: note: in expansion of macro 'statically_true'
70 | #define __is_nonneg(ux) statically_true( \
| ^~~~~~~~~~~~~~~
include/linux/minmax.h:50:14: note: in expansion of macro '__is_nonneg'
50 | (2 + __is_nonneg(ux)) : (1 + 2 * (sizeof(ux) < 4)))
| ^~~~~~~~~~~
include/linux/minmax.h:75:27: note: in expansion of macro '__sign_use'
75 | (__sign_use(ux) & __sign_use(uy))
| ^~~~~~~~~~
include/linux/minmax.h:93:27: note: in expansion of macro '__types_ok'
93 | BUILD_BUG_ON_MSG(!__types_ok(ux, uy), \
| ^~~~~~~~~~
include/linux/minmax.h:98:9: note: in expansion of macro '__careful_cmp_once'
98 | __careful_cmp_once(op, x, y, __UNIQUE_ID(x_), __UNIQUE_ID(y_))
| ^~~~~~~~~~~~~~~~~~
include/linux/minmax.h:112:25: note: in expansion of macro '__careful_cmp'
112 | #define max(x, y) __careful_cmp(max, x, y)
| ^~~~~~~~~~~~~
kernel/sched/fair.c:4066:16: note: in expansion of macro 'max'
4066 | return max(weight, MIN_SHARES);
| ^~~
>> kernel/sched/fair.c:4067:1: warning: control reaches end of non-void function [-Wreturn-type]
4067 | }
| ^
vim +4067 kernel/sched/fair.c
4974c93ce402d6 Peter Zijlstra (Intel 2025-12-06 4050)
4974c93ce402d6 Peter Zijlstra (Intel 2025-12-06 4051) /*
4974c93ce402d6 Peter Zijlstra (Intel 2025-12-06 4052) * weight = NICE_0_LOAD;
4974c93ce402d6 Peter Zijlstra (Intel 2025-12-06 4053) * for_each_entity_se(se)
4974c93ce402d6 Peter Zijlstra (Intel 2025-12-06 4054) * weight = __calc_prop_weight(cfs_rq_of(se), se, weight);
4974c93ce402d6 Peter Zijlstra (Intel 2025-12-06 4055) */
4974c93ce402d6 Peter Zijlstra (Intel 2025-12-06 4056) static __always_inline
4974c93ce402d6 Peter Zijlstra (Intel 2025-12-06 4057) unsigned long __calc_prop_weight(struct cfs_rq *cfs_rq, struct sched_entity *se,
4974c93ce402d6 Peter Zijlstra (Intel 2025-12-06 4058) unsigned long weight)
4974c93ce402d6 Peter Zijlstra (Intel 2025-12-06 4059) {
4974c93ce402d6 Peter Zijlstra (Intel 2025-12-06 4060) weight *= se->load.weight;
4974c93ce402d6 Peter Zijlstra (Intel 2025-12-06 4061) if (parent_entity(se))
4974c93ce402d6 Peter Zijlstra (Intel 2025-12-06 4062) weight /= cfs_rq->load.weight;
4974c93ce402d6 Peter Zijlstra (Intel 2025-12-06 4063) else
4974c93ce402d6 Peter Zijlstra (Intel 2025-12-06 4064) weight /= NICE_0_LOAD;
4974c93ce402d6 Peter Zijlstra (Intel 2025-12-06 4065)
4974c93ce402d6 Peter Zijlstra (Intel 2025-12-06 @4066) return max(weight, MIN_SHARES);
af4cf40470c22e Peter Zijlstra 2023-05-31 @4067 }
9059393e4ec1c8 Vincent Guittot 2017-05-17 4068
:::::: The code at line 4067 was first introduced by commit
:::::: af4cf40470c22efa3987200fd19478199e08e103 sched/fair: Add cfs_rq::avg_vruntime
:::::: TO: Peter Zijlstra <peterz@infradead.org>
:::::: CC: Ingo Molnar <mingo@kernel.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2026-03-20 8:50 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202603201652.XGsoWx79-lkp@intel.com \
--to=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.