From: Simon Horman <horms@kernel.org>
To: Yury Norov <ynorov@nvidia.com>
Cc: "Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"Sunil Goutham" <sgoutham@marvell.com>,
"Linu Cherian" <lcherian@marvell.com>,
"Geetha sowjanya" <gakula@marvell.com>,
"Jerin Jacob" <jerinj@marvell.com>,
"Subbaraya Sundeep" <sbhatta@marvell.com>,
"Stanislav Fomichev" <sdf@fomichev.me>,
"Kuniyuki Iwashima" <kuniyu@google.com>,
"Christian Brauner" <brauner@kernel.org>,
"Yajun Deng" <yajun.deng@linux.dev>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"Thomas Weißschuh" <linux@weissschuh.net>,
"Yury Norov" <yury.norov@gmail.com>
Subject: Re: [PATCH v2 0/2] net: cleanup bitmaps printing
Date: Fri, 20 Mar 2026 17:44:44 +0000 [thread overview]
Message-ID: <20260320174444.GG74886@horms.kernel.org> (raw)
In-Reply-To: <20260319201713.941956-1-ynorov@nvidia.com>
On Thu, Mar 19, 2026 at 04:17:09PM -0400, Yury Norov wrote:
> Bitmap API has a bitmap_print_to_pagebuf() function that is intended to
> print bitmap into a human readable format, making sure that the output
> string will not get big enough to cross the current page limit.
>
> Some drivers use this function immediately before passing the result to
> scnprintf() with no modification. This is useless because scnprintf(),
> and helpers based on it like seq_pritf() and sysfs_emit(), take care of
> not overflowing the buffer by itself, and perfectly print bitmaps with
> "%*pb[l]".
>
> v1: https://lore.kernel.org/all/20260219181407.290201-1-ynorov@nvidia.com/
> v2:
> - fix copy-paste error in print_npa_qsize() (Simon);
> - fix typo in #1 subject (Jakub).
Thanks for the updates.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2026-03-20 17:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 20:17 [PATCH v2 0/2] net: cleanup bitmaps printing Yury Norov
2026-03-19 20:17 ` [PATCH 1/2] octeontx2-af: simplify rvu_debugfs Yury Norov
2026-03-19 20:17 ` [PATCH 2/2] net-sysfs: switch xps_queue_show() to sysfs_emit() Yury Norov
2026-03-20 17:44 ` Simon Horman [this message]
2026-03-24 10:20 ` [PATCH v2 0/2] net: cleanup bitmaps printing patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260320174444.GG74886@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=brauner@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=jerinj@marvell.com \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=lcherian@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sbhatta@marvell.com \
--cc=sdf@fomichev.me \
--cc=sgoutham@marvell.com \
--cc=yajun.deng@linux.dev \
--cc=ynorov@nvidia.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.