From: Nathan Chancellor <nathan@kernel.org>
To: Alice Ryhl <aliceryhl@google.com>
Cc: "Gary Guo" <gary@garyguo.net>, "Rong Xu" <xur@google.com>,
"Han Shen" <shenhan@google.com>,
"Nicolas Schier" <nsc@kernel.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun@kernel.org>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Matthew Maurer" <mmaurer@google.com>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
rust-for-linux@vger.kernel.org
Subject: Re: [PATCH] kbuild: rust: add AutoFDO support
Date: Fri, 20 Mar 2026 14:18:07 -0700 [thread overview]
Message-ID: <20260320211807.GA3990088@ax162> (raw)
In-Reply-To: <abztachY5pOvwM1Q@google.com>
On Fri, Mar 20, 2026 at 06:47:05AM +0000, Alice Ryhl wrote:
> How about we just call them:
>
> * CFLAGS_AUTOFDO_CLANG
> * RUSTFLAGS_AUTOFDO
>
> then? For cflags, clarify that they are clang flags. For rustc, there is
> no such distinction to make (yet).
Yes, that seems reasonable to me (although CFLAGS_AUTOFDO_CLANG is
already the name so I assume you mean just keeping it as it is).
> Another option:
> * CFLAGS_AUTOFDO_CLANG
> * RUSTFLAGS_AUTOFDO_RUSTC
I don't see much of a reason to make this distinction until the rest of
the kernel's Rust code can be built with a different Rust compiler.
Cheers,
Nathan
next prev parent reply other threads:[~2026-03-20 21:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 11:22 [PATCH] kbuild: rust: add AutoFDO support Alice Ryhl
2026-03-19 11:31 ` Gary Guo
2026-03-19 11:44 ` Alice Ryhl
2026-03-19 11:47 ` Gary Guo
2026-03-19 16:33 ` Alice Ryhl
2026-03-19 19:09 ` Gary Guo
2026-03-19 20:37 ` Miguel Ojeda
2026-03-19 23:54 ` Nathan Chancellor
2026-03-20 6:47 ` Alice Ryhl
2026-03-20 21:18 ` Nathan Chancellor [this message]
2026-03-20 21:48 ` Gary Guo
[not found] ` <CAF1bQ=T8-tWaB5Sf2eqWSodMgp=Pf9Guut-JavV62dczHpGNBg@mail.gmail.com>
2026-03-25 17:08 ` Rong Xu
2026-03-25 17:10 ` Rong Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260320211807.GA3990088@ax162 \
--to=nathan@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=mmaurer@google.com \
--cc=nsc@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=shenhan@google.com \
--cc=tmgross@umich.edu \
--cc=xur@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.