All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nithurshen <nithurshen.dev@gmail.com>
To: newajay.11r@gmail.com
Cc: linux-erofs@lists.ozlabs.org, xiang@kernel.org,
	Nithurshen <nithurshen.dev@gmail.com>
Subject: Re: [PATCH] erofs-utils: fix resource leaks and missing returns on error paths
Date: Sat, 21 Mar 2026 10:37:25 +0530	[thread overview]
Message-ID: <20260321050725.60268-1-nithurshen.dev@gmail.com> (raw)
In-Reply-To: <20260320165200.1862-1-newajay.11r@gmail.com>

Hi Xiang,

Both the patches LGTM.

I tested the missing return by truncating an image to force an I/O 
error, and the FUSE daemon now correctly aborts instead of hanging. 
I also dynamically tested the memory leak fix using Valgrind with a 
10MB file and an injected Z_STREAM_ERROR, confirming 0 bytes lost.

The only note is that this should be sent as 2 separate patches in 
the same thread.

Reviewed-by: Nithurshen <nithurshen.dev@gmail.com>
Tested-by: Nithurshen <nithurshen.dev@gmail.com>


  parent reply	other threads:[~2026-03-21  5:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-20 16:52 [PATCH] erofs-utils: fix resource leaks and missing returns on error paths Ajay Rajera
2026-03-20 17:04 ` Nithurshen
2026-03-20 17:20   ` Ajay Rajera
2026-03-20 17:31     ` Nithurshen Karthikeyan
2026-03-21  5:07 ` Nithurshen [this message]
2026-03-21  5:16   ` Gao Xiang
2026-03-21  7:15     ` Nithurshen
2026-03-21 13:39       ` Gao Xiang
2026-03-30  4:41         ` Nithurshen Karthikeyan
2026-03-21  6:31   ` Ajay Rajera

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260321050725.60268-1-nithurshen.dev@gmail.com \
    --to=nithurshen.dev@gmail.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=newajay.11r@gmail.com \
    --cc=xiang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.