From: kernel test robot <lkp@intel.com>
To: Yury Norov <yury.norov@gmail.com>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [norov:new_tests 18/25] drivers/net/ethernet/mellanox/mlx4/fw.c:1302:58: error: expected ';' after expression
Date: Sat, 21 Mar 2026 05:33:01 +0800 [thread overview]
Message-ID: <202603210545.iBzNOFVW-lkp@intel.com> (raw)
tree: https://github.com/norov/linux new_tests
head: 7402f5cc9265ac58854a5e28fa0305bda6f459ab
commit: 9c19f38601eb29dfc08c3db08940f467f48b1d79 [18/25] mellanox: cleanup mlx5_cmd_all_stalled()
config: sparc64-allmodconfig (https://download.01.org/0day-ci/archive/20260321/202603210545.iBzNOFVW-lkp@intel.com/config)
compiler: clang version 23.0.0git (https://github.com/llvm/llvm-project 4abb927bacf37f18f6359a41639a6d1b3bffffb5)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260321/202603210545.iBzNOFVW-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603210545.iBzNOFVW-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/net/ethernet/mellanox/mlx4/fw.c:1302:58: error: expected ';' after expression
1302 | w = bitmap_weight(actv_ports.ports, dev->caps.num_ports)
| ^
| ;
>> drivers/net/ethernet/mellanox/mlx4/fw.c:1319:2: error: call to undeclared function 'FIELD_MODIFY'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
1319 | FIELD_MODIFY(0x0F, &field, w);
| ^
2 errors generated.
--
>> drivers/net/ethernet/mellanox/mlx5/core/cmd.c:1228:45: error: expected ';' in 'for' statement specifier
1228 | for (i = 0, i < cmd->vars.max_reg_cmds; i++) {
| ^
drivers/net/ethernet/mellanox/mlx5/core/cmd.c:1228:16: warning: expression result unused [-Wunused-value]
1228 | for (i = 0, i < cmd->vars.max_reg_cmds; i++) {
| ~ ^ ~~~~~~~~~~~~~~~~~~~~~~
1 warning and 1 error generated.
vim +1302 drivers/net/ethernet/mellanox/mlx4/fw.c
1271
1272 int mlx4_QUERY_DEV_CAP_wrapper(struct mlx4_dev *dev, int slave,
1273 struct mlx4_vhcr *vhcr,
1274 struct mlx4_cmd_mailbox *inbox,
1275 struct mlx4_cmd_mailbox *outbox,
1276 struct mlx4_cmd_info *cmd)
1277 {
1278 u64 flags;
1279 int w, err = 0;
1280 u8 field;
1281 u16 field16;
1282 u32 bmme_flags, field32;
1283 int real_port;
1284 int slave_port;
1285 int first_port;
1286 struct mlx4_active_ports actv_ports;
1287
1288 err = mlx4_cmd_box(dev, 0, outbox->dma, 0, 0, MLX4_CMD_QUERY_DEV_CAP,
1289 MLX4_CMD_TIME_CLASS_A, MLX4_CMD_NATIVE);
1290 if (err)
1291 return err;
1292
1293 disable_unsupported_roce_caps(outbox->buf);
1294 /* add port mng change event capability and disable mw type 1
1295 * unconditionally to slaves
1296 */
1297 MLX4_GET(flags, outbox->buf, QUERY_DEV_CAP_EXT_FLAGS_OFFSET);
1298 flags |= MLX4_DEV_CAP_FLAG_PORT_MNG_CHG_EV;
1299 flags &= ~MLX4_DEV_CAP_FLAG_MEM_WINDOW;
1300 actv_ports = mlx4_get_active_ports(dev, slave);
1301 first_port = find_first_bit(actv_ports.ports, dev->caps.num_ports);
> 1302 w = bitmap_weight(actv_ports.ports, dev->caps.num_ports)
1303 for (slave_port = 0, real_port = first_port;
1304 real_port < first_port + w;
1305 ++real_port, ++slave_port) {
1306 if (flags & (MLX4_DEV_CAP_FLAG_WOL_PORT1 << real_port))
1307 flags |= MLX4_DEV_CAP_FLAG_WOL_PORT1 << slave_port;
1308 else
1309 flags &= ~(MLX4_DEV_CAP_FLAG_WOL_PORT1 << slave_port);
1310 }
1311 for (; slave_port < dev->caps.num_ports; ++slave_port)
1312 flags &= ~(MLX4_DEV_CAP_FLAG_WOL_PORT1 << slave_port);
1313
1314 /* Not exposing RSS IP fragments to guests */
1315 flags &= ~MLX4_DEV_CAP_FLAG_RSS_IP_FRAG;
1316 MLX4_PUT(outbox->buf, flags, QUERY_DEV_CAP_EXT_FLAGS_OFFSET);
1317
1318 MLX4_GET(field, outbox->buf, QUERY_DEV_CAP_VL_PORT_OFFSET);
> 1319 FIELD_MODIFY(0x0F, &field, w);
1320 MLX4_PUT(outbox->buf, field, QUERY_DEV_CAP_VL_PORT_OFFSET);
1321
1322 /* For guests, disable timestamp */
1323 MLX4_GET(field, outbox->buf, QUERY_DEV_CAP_CQ_TS_SUPPORT_OFFSET);
1324 field &= 0x7f;
1325 MLX4_PUT(outbox->buf, field, QUERY_DEV_CAP_CQ_TS_SUPPORT_OFFSET);
1326
1327 /* For guests, disable vxlan tunneling and QoS support */
1328 MLX4_GET(field, outbox->buf, QUERY_DEV_CAP_VXLAN);
1329 field &= 0xd7;
1330 MLX4_PUT(outbox->buf, field, QUERY_DEV_CAP_VXLAN);
1331
1332 /* For guests, disable port BEACON */
1333 MLX4_GET(field, outbox->buf, QUERY_DEV_CAP_PORT_BEACON_OFFSET);
1334 field &= 0x7f;
1335 MLX4_PUT(outbox->buf, field, QUERY_DEV_CAP_PORT_BEACON_OFFSET);
1336
1337 /* For guests, report Blueflame disabled */
1338 MLX4_GET(field, outbox->buf, QUERY_DEV_CAP_BF_OFFSET);
1339 field &= 0x7f;
1340 MLX4_PUT(outbox->buf, field, QUERY_DEV_CAP_BF_OFFSET);
1341
1342 /* For guests, disable mw type 2 and port remap*/
1343 MLX4_GET(bmme_flags, outbox->buf, QUERY_DEV_CAP_BMME_FLAGS_OFFSET);
1344 bmme_flags &= ~MLX4_BMME_FLAG_TYPE_2_WIN;
1345 bmme_flags &= ~MLX4_FLAG_PORT_REMAP;
1346 MLX4_PUT(outbox->buf, bmme_flags, QUERY_DEV_CAP_BMME_FLAGS_OFFSET);
1347
1348 /* turn off device-managed steering capability if not enabled */
1349 if (dev->caps.steering_mode != MLX4_STEERING_MODE_DEVICE_MANAGED) {
1350 MLX4_GET(field, outbox->buf,
1351 QUERY_DEV_CAP_FLOW_STEERING_RANGE_EN_OFFSET);
1352 field &= 0x7f;
1353 MLX4_PUT(outbox->buf, field,
1354 QUERY_DEV_CAP_FLOW_STEERING_RANGE_EN_OFFSET);
1355 }
1356
1357 /* turn off ipoib managed steering for guests */
1358 MLX4_GET(field, outbox->buf, QUERY_DEV_CAP_FLOW_STEERING_IPOIB_OFFSET);
1359 field &= ~0x80;
1360 MLX4_PUT(outbox->buf, field, QUERY_DEV_CAP_FLOW_STEERING_IPOIB_OFFSET);
1361
1362 /* turn off host side virt features (VST, FSM, etc) for guests */
1363 MLX4_GET(field32, outbox->buf, QUERY_DEV_CAP_EXT_2_FLAGS_OFFSET);
1364 field32 &= ~(DEV_CAP_EXT_2_FLAG_VLAN_CONTROL | DEV_CAP_EXT_2_FLAG_80_VFS |
1365 DEV_CAP_EXT_2_FLAG_FSM | DEV_CAP_EXT_2_FLAG_PFC_COUNTERS);
1366 MLX4_PUT(outbox->buf, field32, QUERY_DEV_CAP_EXT_2_FLAGS_OFFSET);
1367
1368 /* turn off QCN for guests */
1369 MLX4_GET(field, outbox->buf, QUERY_DEV_CAP_ECN_QCN_VER_OFFSET);
1370 field &= 0xfe;
1371 MLX4_PUT(outbox->buf, field, QUERY_DEV_CAP_ECN_QCN_VER_OFFSET);
1372
1373 /* turn off QP max-rate limiting for guests */
1374 field16 = 0;
1375 MLX4_PUT(outbox->buf, field16, QUERY_DEV_CAP_QP_RATE_LIMIT_NUM_OFFSET);
1376
1377 /* turn off QoS per VF support for guests */
1378 MLX4_GET(field, outbox->buf, QUERY_DEV_CAP_CQ_EQ_CACHE_LINE_STRIDE);
1379 field &= 0xef;
1380 MLX4_PUT(outbox->buf, field, QUERY_DEV_CAP_CQ_EQ_CACHE_LINE_STRIDE);
1381
1382 /* turn off ignore FCS feature for guests */
1383 MLX4_GET(field, outbox->buf, QUERY_DEV_CAP_CONFIG_DEV_OFFSET);
1384 field &= 0xfb;
1385 MLX4_PUT(outbox->buf, field, QUERY_DEV_CAP_CONFIG_DEV_OFFSET);
1386
1387 return 0;
1388 }
1389
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2026-03-20 21:43 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202603210545.iBzNOFVW-lkp@intel.com \
--to=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.