From: Simon Horman <horms@kernel.org>
To: Damien Dejean <dam.dejean@gmail.com>
Cc: andrew@lunn.ch, krzk+dt@kernel.org, robh@kernel.org,
kuba@kernel.org, maxime.chevallier@bootlin.com,
pabeni@redhat.com, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
edumazet@google.com, davem@davemloft.net, hkallweit1@gmail.com
Subject: Re: [PATCH net-next v9 2/4] net: phy: realtek: add RTL8224 pair order support
Date: Sat, 21 Mar 2026 09:20:14 +0000 [thread overview]
Message-ID: <20260321092014.GV74886@horms.kernel.org> (raw)
In-Reply-To: <46FAC4A6-9462-45BC-B17C-B7F5F19F0ADB@gmail.com>
On Fri, Mar 20, 2026 at 07:17:56PM +0100, Damien Dejean wrote:
>
> > Le 20 mars 2026 à 09:21, Simon Horman <horms@kernel.org> a écrit :
> >
> > Checkpatch warns that ENOSYS only means 'invalid syscall nr'.
> >
> > Looking over the implementation of of_property_read_u32() it seems to me
> > that -EINVAL is sufficient to detect that a property is not present. Which
> > may be appropriate here.
>
> I added the check on -ENOSYS because in v8 Jakub commented [1] on the fact
> that if the kernel is built with CONFIG_OF=n, of_property_read_u32() will
> return ENOSYS. If ENOSYS is not handled there, then the call will return an
> error while it shouldn’t.
Ahh, I see. I missed that in my analysis.
Sorry about that.
>
> Damien
>
> [1] https://lkml.org/lkml/2026/3/17/2464
...
next prev parent reply other threads:[~2026-03-21 9:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-18 21:54 [PATCH net-next v9 0/4] net: phy: realtek: pair order and polarity Damien Dejean
2026-03-18 21:54 ` [PATCH net-next v9 1/4] dt-bindings: net: ethernet-phy: add property enet-phy-pair-order Damien Dejean
2026-03-18 21:54 ` [PATCH net-next v9 2/4] net: phy: realtek: add RTL8224 pair order support Damien Dejean
2026-03-20 8:21 ` Simon Horman
2026-03-20 18:17 ` Damien Dejean
2026-03-21 9:20 ` Simon Horman [this message]
2026-03-18 21:55 ` [PATCH net-next v9 3/4] dt-bindings: net: ethernet-phy: add property enet-phy-pair-polarity Damien Dejean
2026-03-18 21:55 ` [PATCH net-next v9 4/4] net: phy: realtek: add RTL8224 polarity support Damien Dejean
2026-03-21 2:20 ` [PATCH net-next v9 0/4] net: phy: realtek: pair order and polarity patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260321092014.GV74886@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew@lunn.ch \
--cc=dam.dejean@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.