From: Simon Horman <horms@kernel.org>
To: Alexander Wilhelm <alexander.wilhelm@westermo.com>
Cc: Manivannan Sadhasivam <mani@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: qrtr: fix handling of confirm_rx field
Date: Sat, 21 Mar 2026 10:19:26 +0000 [thread overview]
Message-ID: <20260321101926.GY74886@horms.kernel.org> (raw)
In-Reply-To: <20260320-qrtr-fix-confirm_rx-on-big-endian-v1-1-e1a337dc1a38@westermo.com>
On Fri, Mar 20, 2026 at 02:28:52PM +0100, Alexander Wilhelm wrote:
> Convert confirm_rx to little endian when enqueueing by using cpu_to_le32(),
> as big endian systems otherwise interpret the value incorrectly.
>
> When receiving, apply le32_to_cpu(). !! ensures the result becomes 0 or 1
> in native CPU endianness, so this conversion is not strictly required, but
> it is kept for consistency, clarity, and future safety.
Hi Alexander,
It seems to me that the conversion is required if the code
runs on a Big Endian host. What is your thinking on this?
>
> Fixes: 5fdeb0d372ab ("net: qrtr: Implement outgoing flow control")
> Signed-off-by: Alexander Wilhelm <alexander.wilhelm@westermo.com>
...
next prev parent reply other threads:[~2026-03-21 10:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 13:28 [PATCH] net: qrtr: fix handling of confirm_rx field Alexander Wilhelm
2026-03-21 10:19 ` Simon Horman [this message]
2026-03-23 6:51 ` Alexander Wilhelm
2026-03-23 15:32 ` Simon Horman
2026-03-24 7:05 ` Alexander Wilhelm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260321101926.GY74886@horms.kernel.org \
--to=horms@kernel.org \
--cc=alexander.wilhelm@westermo.com \
--cc=andersson@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.