From: Simon Horman <horms@kernel.org>
To: David Carlier <devnexen@gmail.com>
Cc: MD Danish Anwar <danishanwar@ti.com>,
Roger Quadros <rogerq@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH] net: ti: icssg-prueth: fix use-after-free of CPPI descriptor in RX path
Date: Sat, 21 Mar 2026 10:31:48 +0000 [thread overview]
Message-ID: <20260321103148.GZ74886@horms.kernel.org> (raw)
In-Reply-To: <20260320174439.41080-1-devnexen@gmail.com>
On Fri, Mar 20, 2026 at 05:44:39PM +0000, David Carlier wrote:
> cppi5_hdesc_get_psdata() returns a pointer into the CPPI descriptor.
> In both emac_rx_packet() and emac_rx_packet_zc(), the descriptor is
> freed via k3_cppi_desc_pool_free() before the psdata pointer is used
> by emac_rx_timestamp(), which dereferences psdata[0] and psdata[1].
> This constitutes a use-after-free on every received packet that goes
> through the timestamp path.
>
> Defer the descriptor free until after all accesses through the psdata
> pointer are complete. For emac_rx_packet(), move the free into the
> requeue label so both early-exit and success paths free the descriptor
> after all accesses are done. For emac_rx_packet_zc(), move the free to
> the end of the loop body after emac_dispatch_skb_zc() (which calls
> emac_rx_timestamp()) has returned.
>
> Fixes: 46eeb90f03e0 ("net: ti: icssg-prueth: Use page_pool API for RX buffer allocation")
> Signed-off-by: David Carlier <devnexen@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2026-03-21 10:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 18:12 [PATCH net] net: ti: icssg-prueth: fix use-after-free of CPPI descriptor in RX path David Carlier
2026-03-20 17:27 ` Simon Horman
2026-03-20 17:44 ` [PATCH] " David Carlier
2026-03-21 10:31 ` Simon Horman [this message]
2026-03-24 11:30 ` patchwork-bot+netdevbpf
-- strict thread matches above, loose matches on Subject: below --
2026-03-18 9:28 David Carlier
2026-03-19 17:30 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260321103148.GZ74886@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=devnexen@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rogerq@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.