Re: [PATCH] PCI: Use standard wait times for PCIe link monitoring

[kernel test robot <lkp@intel.com>]

Hi Thierry,

kernel test robot noticed the following build errors:

[auto build test ERROR on pci/next]
[also build test ERROR on pci/for-linus linus/master v7.0-rc4 next-20260320]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Thierry-Reding/PCI-Use-standard-wait-times-for-PCIe-link-monitoring/20260321-100847
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next
patch link:    https://lore.kernel.org/r/20260320224044.2569907-1-thierry.reding%40kernel.org
patch subject: [PATCH] PCI: Use standard wait times for PCIe link monitoring
config: s390-randconfig-r071-20260321 (https://download.01.org/0day-ci/archive/20260321/202603211832.idChNb3Y-lkp@intel.com/config)
compiler: clang version 23.0.0git (https://github.com/llvm/llvm-project 4abb927bacf37f18f6359a41639a6d1b3bffffb5)
smatch: v0.5.0-9004-gb810ac53
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260321/202603211832.idChNb3Y-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603211832.idChNb3Y-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/pci/controller/cadence/pcie-cadence-host-common.c:56:30: error: use of undeclared identifier 'PCIE_LINK_WAIT_MAX_RETRIES'
      56 |         for (retries = 0; retries < PCIE_LINK_WAIT_MAX_RETRIES; retries++) {
         |                                     ^~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/pci/controller/cadence/pcie-cadence-host-common.c:61:16: error: use of undeclared identifier 'PCIE_LINK_WAIT_US_MIN'
      61 |                 usleep_range(PCIE_LINK_WAIT_US_MIN, PCIE_LINK_WAIT_US_MAX);
         |                              ^~~~~~~~~~~~~~~~~~~~~
>> drivers/pci/controller/cadence/pcie-cadence-host-common.c:61:39: error: use of undeclared identifier 'PCIE_LINK_WAIT_US_MAX'
      61 |                 usleep_range(PCIE_LINK_WAIT_US_MIN, PCIE_LINK_WAIT_US_MAX);
         |                                                     ^~~~~~~~~~~~~~~~~~~~~
   3 errors generated.


vim +/PCIE_LINK_WAIT_MAX_RETRIES +56 drivers/pci/controller/cadence/pcie-cadence-host-common.c

    48	
    49	int cdns_pcie_host_wait_for_link(struct cdns_pcie *pcie,
    50					 cdns_pcie_linkup_func pcie_link_up)
    51	{
    52		struct device *dev = pcie->dev;
    53		int retries;
    54	
    55		/* Check if the link is up or not */
  > 56		for (retries = 0; retries < PCIE_LINK_WAIT_MAX_RETRIES; retries++) {
    57			if (pcie_link_up(pcie)) {
    58				dev_info(dev, "Link up\n");
    59				return 0;
    60			}
  > 61			usleep_range(PCIE_LINK_WAIT_US_MIN, PCIE_LINK_WAIT_US_MAX);
    62		}
    63	
    64		return -ETIMEDOUT;
    65	}
    66	EXPORT_SYMBOL_GPL(cdns_pcie_host_wait_for_link);
    67	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki