From: Eric Biggers <ebiggers@kernel.org>
To: Demian Shulhan <demyansh@gmail.com>
Cc: David Laight <david.laight.linux@gmail.com>,
ardb@kernel.org, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lib/crc: arm64: add NEON accelerated CRC64-NVMe implementation
Date: Sun, 22 Mar 2026 07:13:20 -0700 [thread overview]
Message-ID: <20260322141320.GA2183@quark> (raw)
In-Reply-To: <CAOLeWCvSokaVROhg7f8pM=G7GaRS9OBp2q4T5WPP18C+wJuyVA@mail.gmail.com>
On Sun, Mar 22, 2026 at 11:29:36AM +0200, Demian Shulhan wrote:
> Hi Eric, David,
>
> Thanks to both of you for the review and suggestions! I've addressed
> all your comments and will send the v2 patch shortly.
>
> The idea of a unified PMULL template for ARM64 is very interesting. I
> can own it and work on it, but as it requires careful design (parallel
> folding across multiple vectors, handling LSB/MSB differences, and
> generalizing Barrett reduction), it will take some time to implement
> and test properly.
>
> Do you think it makes sense to merge this current solution(with fixed
> comments) for now, and I will follow up with the general template
> implementation in a separate patchset later?
>
> Thanks,
> Demian
That sounds good to me. Thanks!
- Eric
next prev parent reply other threads:[~2026-03-22 14:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 6:54 [PATCH] lib/crc: arm64: add NEON accelerated CRC64-NVMe implementation Demian Shulhan
2026-03-19 19:09 ` Eric Biggers
2026-03-20 10:36 ` David Laight
2026-03-20 20:00 ` Eric Biggers
2026-03-22 9:29 ` Demian Shulhan
2026-03-22 14:13 ` Eric Biggers [this message]
2026-03-19 23:31 ` David Laight
2026-03-20 11:22 ` kernel test robot
2026-03-27 6:02 ` [PATCH v2] " Demian Shulhan
2026-03-27 19:38 ` Eric Biggers
2026-03-29 7:43 ` [PATCH v3] " Demian Shulhan
2026-03-29 20:38 ` Eric Biggers
2026-03-29 21:57 ` David Laight
2026-03-29 22:18 ` Eric Biggers
2026-03-30 9:31 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260322141320.GA2183@quark \
--to=ebiggers@kernel.org \
--cc=ardb@kernel.org \
--cc=david.laight.linux@gmail.com \
--cc=demyansh@gmail.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.