From: Leon Romanovsky <leon@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Arnd Bergmann <arnd@kernel.org>,
Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Nathan Chancellor <nathan@kernel.org>,
Mike Marciniszyn <mike.marciniszyn@intel.com>,
"Michael J. Ruhl" <michael.j.ruhl@intel.com>,
Doug Ledford <dledford@redhat.com>,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
Marco Crivellari <marco.crivellari@suse.com>,
Ingo Molnar <mingo@kernel.org>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH 2/3] RDMA/hfi1, rdmavt: open-code rvt_set_ibdev_name()
Date: Mon, 23 Mar 2026 10:08:48 +0200 [thread overview]
Message-ID: <20260323080848.GF814676@unreal> (raw)
In-Reply-To: <6b56c476-86fd-4d43-8dee-c7f89d346941@app.fastmail.com>
On Fri, Mar 20, 2026 at 04:53:04PM +0100, Arnd Bergmann wrote:
> On Fri, Mar 20, 2026, at 16:12, Arnd Bergmann wrote:
>
> > + */
> > + ibdev = &dd->verbs_dev.rdi.ibdev;
> > + dev_set_name(&ibdev->dev, "%s_%d", class_name(), dd->unit);
> > + strscpy(&ibdev->name, dev_name(&ibdev->dev), IB_DEVICE_NAME_MAX);
> > +
>
> I messed this up during a rebase, that should have been
>
> strscpy(ibdev->name, dev_name(&ibdev->dev), IB_DEVICE_NAME_MAX);
>
> (without the extra &). I'll wait for comments before resending.
The hfi1 driver is scheduled for removal. Dennis has already posted the
hfi2 driver, which serves as its replacement.
Thanks
>
> Arnd
>
next prev parent reply other threads:[~2026-03-23 8:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 15:12 [PATCH 1/3] [RESEND] RDMA/hfi1: use a struct group to avoid warning Arnd Bergmann
2026-03-20 15:12 ` [PATCH 2/3] RDMA/hfi1, rdmavt: open-code rvt_set_ibdev_name() Arnd Bergmann
2026-03-20 15:53 ` Arnd Bergmann
2026-03-23 8:08 ` Leon Romanovsky [this message]
2026-03-23 8:48 ` Arnd Bergmann
2026-03-23 11:01 ` Leon Romanovsky
2026-03-23 21:47 ` Dennis Dalessandro
2026-03-24 7:27 ` Arnd Bergmann
2026-03-24 7:51 ` Leon Romanovsky
2026-03-24 7:53 ` Leon Romanovsky
2026-03-23 21:54 ` Dennis Dalessandro
2026-03-22 18:29 ` kernel test robot
2026-03-22 20:12 ` kernel test robot
2026-03-24 1:29 ` kernel test robot
2026-03-20 15:12 ` [PATCH 3/3] RDMA/hfi1: reduce namespace pollution Arnd Bergmann
2026-03-20 18:01 ` [PATCH 1/3] [RESEND] RDMA/hfi1: use a struct group to avoid warning Kees Cook
2026-03-20 21:49 ` yanjun.zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260323080848.GF814676@unreal \
--to=leon@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=justinstitt@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=marco.crivellari@suse.com \
--cc=michael.j.ruhl@intel.com \
--cc=mike.marciniszyn@intel.com \
--cc=mingo@kernel.org \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.