From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C194EEC01A4 for ; Mon, 23 Mar 2026 08:38:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:MIME-Version:Message-ID:Date:To:Sender: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=FqMjRXBNz252qxPpRi4VyrHPmjXuahdLucTePHeybEM=; b=cc4HSZ6vbWnJYpu7UGwt+fdrqq bhYnZFJltzpf3ht+vOY3jCOSNcMgkb7ISgJeiQbKMlzR7p5CfnhyakLASBgDK0c7ffxjncsZzvE3f vAndc2HUq8FuUh9C3TN76mKqpc2ld4QeQeXeI5VBsPVkcworzGQgAOv9oQmv5A20f5bY=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1w4aoH-00063Z-JU; Mon, 23 Mar 2026 08:38:53 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1w4aoF-00063P-NZ for linux-f2fs-devel@lists.sourceforge.net; Mon, 23 Mar 2026 08:38:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-ID: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=qHNN+LYNtk43wPnrnIc4AOnUQVIISSYy4DuiF/HVqOk=; b=bXIV8LJ3v/aVj4B6Gqastu9m1e M9cwyay/jXDyMLoSeg3i2mWkRUcr2aMESNDN1A/IFVufYodYokaDjle0b0zsCwV3AIDBALCxTra/3 raM9+rFRnYgjCx3W0G+tPeEcANtiPwFcIKexmktY1Jvbx4rbwXSojG/YkgYuDBv3/pE0=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:Cc:To:From :Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=qHNN+LYNtk43wPnrnIc4AOnUQVIISSYy4DuiF/HVqOk=; b=j YNaA7EE1jXYY0GDUWSo8D6I8gi9pm4gJVQz4PFQjPqrByFhfaC9rWpvMXGLfMd021PhB7NDF6nhql dPyYK5ZUOTrj2n+hD3CBtJ+KTtsqCdMLsa1RqqnJPCyk+yIw4MRzuThToPSKrPAIb2+/Gq2Htcg6p B4sHjrEHoEeiHOz8=; Received: from sea.source.kernel.org ([172.234.252.31]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1w4aoE-0004ww-VN for linux-f2fs-devel@lists.sourceforge.net; Mon, 23 Mar 2026 08:38:51 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 988AC4433A for ; Mon, 23 Mar 2026 08:38:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C3BFC4CEF7; Mon, 23 Mar 2026 08:38:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774255120; bh=QwZEFeorxpwCaeP5jW8KMO6XgxyYHA/q67+XPWrH+zY=; h=From:To:Cc:Subject:Date:From; b=Sgcbhy+awME8QoAXZtV+/1Rn6iADBlR5tLh+8y6jTh+02ZxgUzJ9GcSzArjM1bxlb y12BxJF3wvPs9qMXZ6iEIWopmNLJQqDGfo+CDwQxvOinGBrwkiWSLQOjjYJUY/Qisn SBTPxor60ETYjAdpcmyB4Du763sqgzbd4jL42OjFWdPE43zvzmd2h7J1lKIxr7OKsx ccaO7FGV2KvgRJQ6xa1AbTtE+Rnik4/GpR5qMHZEDPDEnsXtm4wGXWO8P74VaaBVhm 5AGC0uGjnZEF506FcOcVgmAkDkPbxmm3PIxwy6RBnWnzchWzX4ojeHiZeqmcp5UzyB H1fLtKFMVMj5Q== To: jaegeuk@kernel.org Date: Mon, 23 Mar 2026 16:38:32 +0800 Message-ID: <20260323083834.156393-1-chao@kernel.org> X-Mailer: git-send-email 2.53.0.959.g497ff81fa9-goog MIME-Version: 1.0 X-Headers-End: 1w4aoE-0004ww-VN Subject: [f2fs-dev] [PATCH v3 1/2] f2fs: call f2fs_handle_critical_error() to set cp_error flag X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Chao Yu via Linux-f2fs-devel Reply-To: Chao Yu Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net f2fs_handle_page_eio() is the only left place we set CP_ERROR_FLAG directly, it missed to update superblock.s_stop_reason, let's call f2fs_handle_critical_error() instead to fix that. Introduce STOP_CP_REASON_READ_{META,NODE,DATA} stop_cp_reason enum variable to indicate which kind of data we failed to read. Signed-off-by: Chao Yu --- v3: - No changes. fs/f2fs/f2fs.h | 21 +++++++++++++++++++-- include/linux/f2fs_fs.h | 3 +++ 2 files changed, 22 insertions(+), 2 deletions(-) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index 660bf88a376f..94cf1e78d892 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -5073,8 +5073,25 @@ static inline void f2fs_handle_page_eio(struct f2fs_sb_info *sbi, return; if (ofs == sbi->page_eio_ofs[type]) { - if (sbi->page_eio_cnt[type]++ == MAX_RETRY_PAGE_EIO) - set_ckpt_flags(sbi, CP_ERROR_FLAG); + if (sbi->page_eio_cnt[type]++ == MAX_RETRY_PAGE_EIO) { + enum stop_cp_reason stop_reason; + + switch (type) { + case META: + stop_reason = STOP_CP_REASON_READ_META; + break; + case NODE: + stop_reason = STOP_CP_REASON_READ_NODE; + break; + case DATA: + stop_reason = STOP_CP_REASON_READ_DATA; + break; + default: + f2fs_bug_on(sbi, 1); + return; + } + f2fs_handle_critical_error(sbi, stop_reason); + } } else { sbi->page_eio_ofs[type] = ofs; sbi->page_eio_cnt[type] = 0; diff --git a/include/linux/f2fs_fs.h b/include/linux/f2fs_fs.h index dc41722fcc9d..829a59399dac 100644 --- a/include/linux/f2fs_fs.h +++ b/include/linux/f2fs_fs.h @@ -80,6 +80,9 @@ enum stop_cp_reason { STOP_CP_REASON_NO_SEGMENT, STOP_CP_REASON_CORRUPTED_FREE_BITMAP, STOP_CP_REASON_CORRUPTED_NID, + STOP_CP_REASON_READ_META, + STOP_CP_REASON_READ_NODE, + STOP_CP_REASON_READ_DATA, STOP_CP_REASON_MAX, }; -- 2.49.0 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C5ED381AE7 for ; Mon, 23 Mar 2026 08:38:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774255121; cv=none; b=cWcRG3+GcBEdnB/YnEX+LWhGpKUsdc0HRLepQHvQSXYPt00cUgLvGY43WiAuOUVRa6joOTYUz3ZR3kWyoQM7O2Ubj8+MBpiLlXpIqba14F22JnC5gs24qCmwoMgqtBnlwpMwqZgF07V5h+buPF41/ByqhXH4GW2fL7SxKy/YfnM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774255121; c=relaxed/simple; bh=QwZEFeorxpwCaeP5jW8KMO6XgxyYHA/q67+XPWrH+zY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Ea1zZE1QxG+aLaqf2zqI99JeSgoYi+HROzn0GwvfOsGUL+6dKuyFn7mfZyYYNgc70loMk5UJq+LTcU/CWBQG4mwd0CcgIr3l+MRUrbknwbap4VPoNA9VGoQMWV32qzMNW/G9klPwE8IKre6qUPrMPlkioIyR9aQxIN5WuOvH3ck= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Sgcbhy+a; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Sgcbhy+a" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C3BFC4CEF7; Mon, 23 Mar 2026 08:38:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774255120; bh=QwZEFeorxpwCaeP5jW8KMO6XgxyYHA/q67+XPWrH+zY=; h=From:To:Cc:Subject:Date:From; b=Sgcbhy+awME8QoAXZtV+/1Rn6iADBlR5tLh+8y6jTh+02ZxgUzJ9GcSzArjM1bxlb y12BxJF3wvPs9qMXZ6iEIWopmNLJQqDGfo+CDwQxvOinGBrwkiWSLQOjjYJUY/Qisn SBTPxor60ETYjAdpcmyB4Du763sqgzbd4jL42OjFWdPE43zvzmd2h7J1lKIxr7OKsx ccaO7FGV2KvgRJQ6xa1AbTtE+Rnik4/GpR5qMHZEDPDEnsXtm4wGXWO8P74VaaBVhm 5AGC0uGjnZEF506FcOcVgmAkDkPbxmm3PIxwy6RBnWnzchWzX4ojeHiZeqmcp5UzyB H1fLtKFMVMj5Q== From: Chao Yu To: jaegeuk@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Chao Yu Subject: [PATCH v3 1/2] f2fs: call f2fs_handle_critical_error() to set cp_error flag Date: Mon, 23 Mar 2026 16:38:32 +0800 Message-ID: <20260323083834.156393-1-chao@kernel.org> X-Mailer: git-send-email 2.53.0.959.g497ff81fa9-goog Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit f2fs_handle_page_eio() is the only left place we set CP_ERROR_FLAG directly, it missed to update superblock.s_stop_reason, let's call f2fs_handle_critical_error() instead to fix that. Introduce STOP_CP_REASON_READ_{META,NODE,DATA} stop_cp_reason enum variable to indicate which kind of data we failed to read. Signed-off-by: Chao Yu --- v3: - No changes. fs/f2fs/f2fs.h | 21 +++++++++++++++++++-- include/linux/f2fs_fs.h | 3 +++ 2 files changed, 22 insertions(+), 2 deletions(-) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index 660bf88a376f..94cf1e78d892 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -5073,8 +5073,25 @@ static inline void f2fs_handle_page_eio(struct f2fs_sb_info *sbi, return; if (ofs == sbi->page_eio_ofs[type]) { - if (sbi->page_eio_cnt[type]++ == MAX_RETRY_PAGE_EIO) - set_ckpt_flags(sbi, CP_ERROR_FLAG); + if (sbi->page_eio_cnt[type]++ == MAX_RETRY_PAGE_EIO) { + enum stop_cp_reason stop_reason; + + switch (type) { + case META: + stop_reason = STOP_CP_REASON_READ_META; + break; + case NODE: + stop_reason = STOP_CP_REASON_READ_NODE; + break; + case DATA: + stop_reason = STOP_CP_REASON_READ_DATA; + break; + default: + f2fs_bug_on(sbi, 1); + return; + } + f2fs_handle_critical_error(sbi, stop_reason); + } } else { sbi->page_eio_ofs[type] = ofs; sbi->page_eio_cnt[type] = 0; diff --git a/include/linux/f2fs_fs.h b/include/linux/f2fs_fs.h index dc41722fcc9d..829a59399dac 100644 --- a/include/linux/f2fs_fs.h +++ b/include/linux/f2fs_fs.h @@ -80,6 +80,9 @@ enum stop_cp_reason { STOP_CP_REASON_NO_SEGMENT, STOP_CP_REASON_CORRUPTED_FREE_BITMAP, STOP_CP_REASON_CORRUPTED_NID, + STOP_CP_REASON_READ_META, + STOP_CP_REASON_READ_NODE, + STOP_CP_REASON_READ_DATA, STOP_CP_REASON_MAX, }; -- 2.49.0