All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeevan B <jeevan.b@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: jouni.hogander@intel.com, Jeevan B <jeevan.b@intel.com>
Subject: [PATCH i-g-t 1/4] tests/intel/kms_fbc_dirty_rect: Avoid unnecessary PSR disable
Date: Mon, 23 Mar 2026 14:42:02 +0530	[thread overview]
Message-ID: <20260323091205.100585-2-jeevan.b@intel.com> (raw)
In-Reply-To: <20260323091205.100585-1-jeevan.b@intel.com>

Pass output to psr_sink_support so PSR is disabled only when the
sink supports it. Using NULL performs a global check, which is
unnecessary and can be incorrect on multi-eDP systems.

Signed-off-by: Jeevan B <jeevan.b@intel.com>
---
 tests/intel/kms_fbc_dirty_rect.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/intel/kms_fbc_dirty_rect.c b/tests/intel/kms_fbc_dirty_rect.c
index efbd46985..e7634dbab 100644
--- a/tests/intel/kms_fbc_dirty_rect.c
+++ b/tests/intel/kms_fbc_dirty_rect.c
@@ -414,9 +414,9 @@ static bool prepare_test(data_t *data)
 	igt_require_f(intel_fbc_supported(data->crtc),
 		      "FBC not supported by the chipset on pipe\n");
 
-	if (psr_sink_support(data->drm_fd, data->debugfs_fd, PSR_MODE_1, NULL) ||
-	    psr_sink_support(data->drm_fd, data->debugfs_fd, PSR_MODE_2, NULL) ||
-	    psr_sink_support(data->drm_fd, data->debugfs_fd, PR_MODE, NULL)) {
+	if (psr_sink_support(data->drm_fd, data->debugfs_fd, PSR_MODE_1, data->output) ||
+	    psr_sink_support(data->drm_fd, data->debugfs_fd, PSR_MODE_2, data->output) ||
+	    psr_sink_support(data->drm_fd, data->debugfs_fd, PR_MODE, data->output)) {
 		igt_info("PSR is supported by the sink. Disabling PSR to test Dirty FBC functionality.\n");
 		psr_disable(data->drm_fd, data->debugfs_fd, data->output);
 	}
-- 
2.43.0


  reply	other threads:[~2026-03-23  9:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-23  9:12 [PATCH i-g-t 0/4] Fix PSR handling for multi-eDP systems Jeevan B
2026-03-23  9:12 ` Jeevan B [this message]
2026-03-25 14:49   ` [PATCH i-g-t 1/4] tests/intel/kms_fbc_dirty_rect: Avoid unnecessary PSR disable Samala, Pranay
2026-03-25 15:12     ` Samala, Pranay
2026-03-23  9:12 ` [PATCH i-g-t 2/4] tests/kms_vrr: " Jeevan B
2026-03-23  9:12 ` [PATCH i-g-t 3/4] tests/intel/kms_psr_stress_test: Select PSR-capable output Jeevan B
2026-03-25 15:38   ` Samala, Pranay
2026-03-23  9:12 ` [PATCH i-g-t 4/4] tests/intel/kms_pm_dc: Scope PSR handling to output Jeevan B
2026-04-14  8:25   ` Samala, Pranay
2026-03-23 14:41 ` ✓ Xe.CI.BAT: success for Fix PSR handling for multi-eDP systems (rev2) Patchwork
2026-03-23 16:08 ` ✓ i915.CI.BAT: " Patchwork
2026-03-23 16:08 ` Patchwork
2026-03-23 20:24 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-03-23 22:59 ` ✗ i915.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260323091205.100585-2-jeevan.b@intel.com \
    --to=jeevan.b@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jouni.hogander@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.